Date: Tue, 15 Jun 1999 11:14:59 -0700 (PDT) From: Matthew Jacob <mjacob@feral.com> To: Guido van Rooij <guido@gvr.org> Cc: Matthew Dillon <dillon@apollo.backplane.com>, freebsd-hackers@FreeBSD.ORG, peter@FreeBSD.ORG Subject: to be more precise... Message-ID: <Pine.BSF.4.05.9906151111500.5752-100000@semuta.feral.com> In-Reply-To: <19990615200947.B3803@gvr.org>
next in thread | previous in thread | raw e-mail | index | archive | help
The actual code of interest is:
FreeBSD:
* $Id: nfs_node.c,v 1.28.2.1 1999/06/07 00:04:05 peter Exp $
or
* $Id: nfs_node.c,v 1.29 1999/06/05 05:26:36 peter Exp $
...
/*
* Insert the nfsnode in the hash queue for its new file handle
*/
for (np2 = nhpp->lh_first; np2 != 0; np2 = np2->n_hash.le_next) {
if (mntp != NFSTOV(np)->v_mount || np2->n_fhsize != fhsize ||
bcmp((caddr_t)fhp, (caddr_t)np2->n_fhp, fhsize))
continue;
vrele(vp);
goto retry;
}
OpenBSD:
/* $OpenBSD: nfs_node.c,v 1.13 1999/04/28 09:28:17 art Exp $ */
...
/*
* Insert the nfsnode in the hash queue for its new file handle
*/
for (np2 = nhpp->lh_first; np2 != 0; np2 = np2->n_hash.le_next) {
if (vp->v_mount != NFSTOV(np2)->v_mount ||
fhsize != np2->n_fhsize ||
bcmp((caddr_t)fhp, (caddr_t)np2->n_fhp, fhsize))
continue;
vrele(vp);
goto retry;
}
For OpenBSD and FreeBSD it's a memory leak for the allocated nfsnode *np.
For FreeBSD it's also the locking foop.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.05.9906151111500.5752-100000>