From owner-freebsd-hackers  Tue Jun 15 11:15:23 1999
Delivered-To: freebsd-hackers@freebsd.org
Received: from feral.com (feral.com [192.67.166.1])
	by hub.freebsd.org (Postfix) with ESMTP
	id 33A9115647; Tue, 15 Jun 1999 11:15:20 -0700 (PDT)
	(envelope-from mjacob@feral.com)
Received: from semuta.feral.com (semuta [192.67.166.70])
	by feral.com (8.8.7/8.8.7) with ESMTP id LAA19654;
	Tue, 15 Jun 1999 11:15:12 -0700
Date: Tue, 15 Jun 1999 11:14:59 -0700 (PDT)
From: Matthew Jacob <mjacob@feral.com>
Reply-To: mjacob@feral.com
To: Guido van Rooij <guido@gvr.org>
Cc: Matthew Dillon <dillon@apollo.backplane.com>,
	freebsd-hackers@FreeBSD.ORG, peter@FreeBSD.ORG
Subject: to be more precise...
In-Reply-To: <19990615200947.B3803@gvr.org>
Message-ID: <Pine.BSF.4.05.9906151111500.5752-100000@semuta.feral.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


The actual code of interest is:

FreeBSD:
 * $Id: nfs_node.c,v 1.28.2.1 1999/06/07 00:04:05 peter Exp $
or
 * $Id: nfs_node.c,v 1.29 1999/06/05 05:26:36 peter Exp $
...

        /*
         * Insert the nfsnode in the hash queue for its new file handle
         */
        for (np2 = nhpp->lh_first; np2 != 0; np2 = np2->n_hash.le_next) {
                if (mntp != NFSTOV(np)->v_mount || np2->n_fhsize != fhsize ||
                    bcmp((caddr_t)fhp, (caddr_t)np2->n_fhp, fhsize))
                        continue;
                vrele(vp);
                goto retry;
        }


OpenBSD:
/*      $OpenBSD: nfs_node.c,v 1.13 1999/04/28 09:28:17 art Exp $       */
...
        /*
         * Insert the nfsnode in the hash queue for its new file handle
         */
        for (np2 = nhpp->lh_first; np2 != 0; np2 = np2->n_hash.le_next) {
                if (vp->v_mount != NFSTOV(np2)->v_mount ||
                    fhsize != np2->n_fhsize ||
                    bcmp((caddr_t)fhp, (caddr_t)np2->n_fhp, fhsize))
                        continue;

                vrele(vp);
                goto retry;
        }

For OpenBSD and FreeBSD it's a memory leak for the allocated nfsnode *np.
For FreeBSD it's also the locking foop.





To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message