From owner-cvs-src@FreeBSD.ORG  Tue Mar 23 05:01:20 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2E2F816A4CE; Tue, 23 Mar 2004 05:01:20 -0800 (PST)
Received: from mx.nsu.ru (mx.nsu.ru [212.192.164.5])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id B20B043D49; Tue, 23 Mar 2004 05:01:19 -0800 (PST)
	(envelope-from danfe@regency.nsu.ru)
Received: from regency.nsu.ru ([193.124.210.26])
	by mx.nsu.ru with esmtp (Exim 4.30)
	id 1B5lXv-00010l-2L; Tue, 23 Mar 2004 19:02:19 +0600
Received: from regency.nsu.ru (localhost [127.0.0.1])
	by regency.nsu.ru (8.12.10/8.12.10) with ESMTP id i2ND2a2a053006;
	Tue, 23 Mar 2004 19:02:36 +0600 (NOVT)
	(envelope-from danfe@regency.nsu.ru)
Received: (from danfe@localhost)
	by regency.nsu.ru (8.12.10/8.12.10/Submit) id i2ND2ajQ052971;
	Tue, 23 Mar 2004 19:02:36 +0600 (NOVT)
	(envelope-from danfe)
Date: Tue, 23 Mar 2004 19:02:36 +0600
From: Alexey Dokuchaev <danfe@nsu.ru>
To: Bill Paul <wpaul@freebsd.org>
Message-ID: <20040323130235.GB39851@regency.nsu.ru>
References: <20040322102119.P33645@root.org>
	<20040322191542.CD8DE16A4CF@hub.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040322191542.CD8DE16A4CF@hub.freebsd.org>
User-Agent: Mutt/1.4.1i
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: Nate Lawson <nate@root.org>
Subject: Re: cvs commit: src/sys/amd64/isa atpic.c src/sys/contrib/dev/oltr
	if_oltr.c src/sys/dev/aac aac_pci.c src/sys/dev/acpic
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 23 Mar 2004 13:01:20 -0000

On Mon, Mar 22, 2004 at 11:15:42AM -0800, Bill Paul wrote:
> 
> This is the entire bus_alloc_resource_any() function:
> 
> static __inline struct resource *
> bus_alloc_resource_any(device_t dev, int type, int *rid, u_int flags)
> {
>         return (bus_alloc_resource(dev, type, rid, 0ul, ~0ul, 1, flags));
> }
> 
> Please to be explaining why this isn't a macro:
> 
> #define bus_alloc_resource_any(dev, type, rid, flags)	\
> 	bus_alloc_resource(dev, type, rid, 0ul, ~0ul, 1, flags)

Pardon my sneaking in discussion, but I also wonder why isn't this a
macro?  I probably should blame myself for not looking at the actual
diff when I received your commit message, but I was pretty sure that
you've just added a macro like Bill suggested above.

./danfe