From owner-freebsd-current Wed Jul 11 23:44:56 2001 Delivered-To: freebsd-current@freebsd.org Received: from sneakerz.org (sneakerz.org [216.33.66.254]) by hub.freebsd.org (Postfix) with ESMTP id 5477A37B403; Wed, 11 Jul 2001 23:44:53 -0700 (PDT) (envelope-from bright@sneakerz.org) Received: by sneakerz.org (Postfix, from userid 1092) id AB2115D01F; Thu, 12 Jul 2001 01:44:44 -0500 (CDT) Date: Thu, 12 Jul 2001 01:44:44 -0500 From: Alfred Perlstein To: Seigo Tanimura Cc: jake@FreeBSD.org, jhb@FreeBSD.org, current@FreeBSD.org Subject: Re: Lock of struct filedesc, file, pgrp, session and sigio Message-ID: <20010712014442.E2449@sneakerz.org> References: <200106040748.f547mUD53783@rina.r.dl.itc.u-tokyo.ac.jp> <200106181004.f5IA4VD63112@rina.r.dl.itc.u-tokyo.ac.jp> <200107020812.f628CfK44241@rina.r.dl.itc.u-tokyo.ac.jp> <20010707164249.C88962@sneakerz.org> <20010709032044.B1894@sneakerz.org> <200107100845.f6A8jqt99404@rina.r.dl.itc.u-tokyo.ac.jp> <20010710035347.Q1894@sneakerz.org> <200107100903.f6A93et02367@rina.r.dl.itc.u-tokyo.ac.jp> <200107111137.f6BBbQt22812@rina.r.dl.itc.u-tokyo.ac.jp> <20010712014205.D2449@sneakerz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2i In-Reply-To: <20010712014205.D2449@sneakerz.org>; from bright@sneakerz.org on Thu, Jul 12, 2001 at 01:42:05AM -0500 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Alfred Perlstein [010712 01:42] wrote: > * Seigo Tanimura [010711 19:08] wrote: > > > > The patch and the results of build test are now on the web page. > > > > The discussion of ktrace(2) problem does not cover the solution of > > BSD/OS, so it needs updating. > > I'm just reviewing the file stuff, I have a number of updates mainly > in the areas of needing FFIND_HOLD/fdrop rather than just a simple > FFIND. > > getvnode(p->p_fd, args->fd, &fp); > > I'm quite sure should implicitly do a FHOLD operation on the returned > struct file, i don't see this, at least not in linux_getdents() > (compat/linux/linux_file.c). Or at least an fhold needs to be done before relasing the lock on the struct file. -- -Alfred Perlstein [alfred@freebsd.org] Ok, who wrote this damn function called '??'? And why do my programs keep crashing in it? To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message