From owner-freebsd-bugs@freebsd.org  Fri Oct  6 01:30:12 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 57A15E21407
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Fri,  6 Oct 2017 01:30:12 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 451C369A93
 for <freebsd-bugs@FreeBSD.org>; Fri,  6 Oct 2017 01:30:12 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v961UBqM036425
 for <freebsd-bugs@FreeBSD.org>; Fri, 6 Oct 2017 01:30:12 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 222807] PURE entropy sources are harvested but not mixed in.
 Also, min-entropy low per SP800-90B measurements
Date: Fri, 06 Oct 2017 01:30:12 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: kern
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: cem@freebsd.org
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-222807-8-76fv0qEiVp@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-222807-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-222807-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Oct 2017 01:30:12 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D222807

--- Comment #6 from Conrad Meyer <cem@freebsd.org> ---
So hc_source_mask is initialized to RANDOM_HARVEST_EVERYTHING_MASK.

Is expanding RANDOM_HARVEST_EVERYTHING_MASK to cover the Pure devices
sufficient to harvest from RDRAND and Via?  Or would that break anything (e=
.g.,
due to the devices that did not register)?

Yes, the rest of the 1st patch is a nice enhancement to expose those bits to
userspace that were not exposed before.  I'm just not clear on if the bits =
must
only be set on registration, or if it's ok to just have them all set from t=
he
beginning.

Thanks!

Would you mind throwing the patches up on Phabricator so comments can be mo=
re
clearly associated with specific lines of code?

--=20
You are receiving this mail because:
You are the assignee for the bug.=