From owner-svn-src-all@FreeBSD.ORG Mon Aug 19 12:13:36 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id ADC38E15 for ; Mon, 19 Aug 2013 12:13:36 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1F8472A6F for ; Mon, 19 Aug 2013 12:13:35 +0000 (UTC) Received: (qmail 66615 invoked from network); 19 Aug 2013 12:57:03 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 19 Aug 2013 12:57:03 -0000 Message-ID: <52120BEC.4050604@freebsd.org> Date: Mon, 19 Aug 2013 14:13:32 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Davide Italiano Subject: Re: svn commit: r254520 - in head/sys: kern sys References: <201308191116.r7JBGsc6065793@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Aug 2013 12:13:36 -0000 On 19.08.2013 13:23, Davide Italiano wrote: > On Mon, Aug 19, 2013 at 1:16 PM, Andre Oppermann wrote: >> Modified: head/sys/sys/mbuf.h >> ============================================================================== >> --- head/sys/sys/mbuf.h Mon Aug 19 11:08:36 2013 (r254519) >> +++ head/sys/sys/mbuf.h Mon Aug 19 11:16:53 2013 (r254520) >> @@ -200,7 +200,7 @@ struct mbuf { >> /* 0x00008000 free */ >> #define M_VLANTAG 0x00010000 /* ether_vtag is valid */ >> #define M_PROMISC 0x00020000 /* packet was not for us */ >> -#define M_NOFREE 0x00040000 /* do not free mbuf, embedded in cluster */ >> + /* 0x00040000 free */ > > I think you should just use M_UNUSED or something similar here for > consistency, like it's happening in td_pflags (sys/sys/proc.h), e.g.: > > #define TDP_UNUSED9 0x00000100 /* --available-- */ There's a couple of more changes upcoming that will take care of it. -- Andre