From owner-freebsd-rc@FreeBSD.ORG Wed Dec 29 11:44:35 2010 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 10664106566C; Wed, 29 Dec 2010 11:44:35 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 6AE1E8FC16; Wed, 29 Dec 2010 11:44:34 +0000 (UTC) Received: by wyf19 with SMTP id 19so9908958wyf.13 for ; Wed, 29 Dec 2010 03:44:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=96iK/2t+bpGvYd9Xq7cw0TDmOSnRWm5gj5qPj+a7M+w=; b=hi0ILckmMdkYNhsgo7zdYjPOJpglLyX9S6TAdfnhowVaSUredr3odxuvv8kObDRMkt 7vzE+4d4gLCXyn4I7YyTZqNzwVrAkltMa585R+cfe8VUBNC5m2JlNL9Lwq5kbEKe4SQO VO9xfrBDpDUEYq/ggtOewEFXQ6z6N4SyEbIJw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=pdotMa+YuGQE3iBgQspIQLdJ9QRFgtmhP2Mwi8BcuyFc0BKXCNcBGnwoZu3Ys7jbgY qnb464XRWHOdKZnHUWes8rwaSFoQKNusRp275j01pj3lWJujPHSyTFrSf3I7i1yyuKIT qiflF+nooTjLvc2vLy3fwBGGNdLllUQay0skI= MIME-Version: 1.0 Received: by 10.216.78.146 with SMTP id g18mr2870087wee.1.1293623073370; Wed, 29 Dec 2010 03:44:33 -0800 (PST) Received: by 10.216.254.226 with HTTP; Wed, 29 Dec 2010 03:44:33 -0800 (PST) In-Reply-To: <4D1A3DFE.8090009@FreeBSD.org> References: <201012272253.oBRMrH7k025331@freefall.freebsd.org> <1232C1B4-DA64-4332-906E-288B8C1E39FE@gmail.com> <4D1A3DFE.8090009@FreeBSD.org> Date: Wed, 29 Dec 2010 03:44:33 -0800 Message-ID: From: Garrett Cooper To: Doug Barton Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-rc@FreeBSD.org" , "ggg_mail@inbox.ru" Subject: Re: conf/153460: devd(8) cannot be restarted correctly via /etc/rc.d script X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Dec 2010 11:44:35 -0000 Yeah, and while I do agree there are some issues with the change. For starters, devd.conf does also have a pid-file directive so the .conf file and the rc script can get out of sync: http://www.freebsd.org/cgi/man.cgi?query=devd.conf&sektion=5&apropos=0&manpath=FreeBSD+8.1-RELEASE . There was also an issue with devd that needs to be resolved so that file descriptors are closed properly. That is most likely the root cause of the issue that the OP is seeing: http://unix.derkeiler.com/Mailing-Lists/FreeBSD/current/2010-06/msg00811.html . Warner MFCed the change a while back IIRC, but it's still worth checking. So this might address one other part of the bug (the rc-script part), but unfortunately the pidfile variable needs to be massaged according to the devd.conf file; thankfully that's static as there isn't a devd_flags or devd_args variable :). Thanks for the followup! -Garrett On Tue, Dec 28, 2010 at 11:43 AM, Doug Barton wrote: > Did you actually read the PR, or my change? > > On 12/28/2010 02:09, Garrett Cooper wrote: >> >> Uh, pretty sure it was a devd bug that was fixed on current several months >> back by imp that I originally reported on current@. The reporter should >> check and see if devd updated to stable-8 solves the reported issue. fstat >> output on the pidfile would help too. >> -Garrett >> >> Sent from my iPhone >> >> On Dec 27, 2010, at 10:53 PM, dougb@FreeBSD.org wrote: >> >>> Synopsis: devd(8) cannot be restarted correctly via /etc/rc.d script >>> >>> State-Changed-From-To: open->patched >>> State-Changed-By: dougb >>> State-Changed-When: Mon Dec 27 22:50:32 UTC 2010 >>> State-Changed-Why: >>> >>> Patched in r216744 >>> >>> >>> Responsible-Changed-From-To: freebsd-rc->dougb >>> Responsible-Changed-By: dougb >>> Responsible-Changed-When: Mon Dec 27 22:50:32 UTC 2010 >>> Responsible-Changed-Why: >>> >>> I did the change, I'll handled the MFC