From owner-dev-commits-src-main@freebsd.org Mon May 3 21:09:43 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C4F7B63DC4C; Mon, 3 May 2021 21:09:43 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf2b.google.com (mail-qv1-xf2b.google.com [IPv6:2607:f8b0:4864:20::f2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FYwbC4z36z3kbK; Mon, 3 May 2021 21:09:43 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qv1-xf2b.google.com with SMTP id jm10so3379722qvb.5; Mon, 03 May 2021 14:09:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=4RwtE0kenZqRa+dtUu8k58tCG99Yq5Ak8QZ27XkKHG4=; b=ngh7zHR6SYSrz0szF6iUFEN0sJxpe3wGjsmy/EvsMvDazWqjB4ggqV3tKZRRykNw4l Trd0yr4IkavJoxkieO93hQXVoYMTp9VA3uKMmFCrYbiZLLPm5XqjJLil7AxjIR9Xw8h2 o74zC/Mvv8WiAYUIBqHoJIXE8Rwu0JLUvhqo3MZDwVWOJ92UtZdMhPwo0b8APvLa5GaD O5+n705DCreYpcl6KVHlxMEqY9jUsJFynqtKhysKmtuoOHBDS3WOqq7vFbvkJhzYkJSV dETwBQQK2jq9iTrNOnpsBbyhHMIJMn5kDbfhHdm5VQu8sACBfxhB1kExVdDQ76jI5ujS f0tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=4RwtE0kenZqRa+dtUu8k58tCG99Yq5Ak8QZ27XkKHG4=; b=ipNkCYKMUQo1A4W/0BzCmgAXUQ7t7dg2lzUm/rEdoSVnUIA4EZ5kDqE1HqJbUNQ5P0 BeCp/CBZmdukg1rZq2g2zRDdp35KO8f0NOM3Qec19Of2iP9d7lMeshvBUt0oW8cMgyIW AXWlr52ALLoZ9qPF8stkzdM2XODFVyzd6G2CbOatMBO+J4CKSsc8iiWOHvTjhnZzE7fo jllrlADNqwmrQL2G7LpB2YMDpjR1FwhgbyoaJhL9SafPYc8+fmDiHKiXsOd8jIKOyoWF WIwKbhA+3866udDAPAOLHniDRZGSr+8Syo7djqxTHphFELLb2o+lvEnndzxEpRTnejO8 VEiw== X-Gm-Message-State: AOAM532OB7MxHcCkeQUr429DACK2blBpmNOkeaNVw8B6eLkE+ty1HexR xdmfY7hnoMpF3GacX0qYO+9BBJOMUyGCjQ== X-Google-Smtp-Source: ABdhPJzOppMafHmzZ0dW42lBddlA4bCenf+DKKvOoRaC9pXInSQ+NbBwgo3+QZCZ9B5CKa50gIl+tQ== X-Received: by 2002:a0c:bd2b:: with SMTP id m43mr22052860qvg.52.1620076181913; Mon, 03 May 2021 14:09:41 -0700 (PDT) Received: from nuc ([142.126.164.150]) by smtp.gmail.com with ESMTPSA id j22sm1481859qkk.58.2021.05.03.14.09.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 May 2021 14:09:41 -0700 (PDT) Sender: Mark Johnston Date: Mon, 3 May 2021 17:09:42 -0400 From: Mark Johnston To: Allan Jude Cc: Kevin Bowling , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, src-committers@freebsd.org Subject: Re: git: 64881da47807 - main - ixgbe: Restore AIM support Message-ID: References: <202105031755.143Htj33046938@gitrepo.freebsd.org> <295b05d0-58ba-6e04-6fbf-cb997c9ab112@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <295b05d0-58ba-6e04-6fbf-cb997c9ab112@freebsd.org> X-Rspamd-Queue-Id: 4FYwbC4z36z3kbK X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 May 2021 21:09:43 -0000 On Mon, May 03, 2021 at 03:30:55PM -0400, Allan Jude wrote: > On 5/3/2021 2:12 PM, Kevin Bowling wrote: > > Should we enable this by default?  My primary concern in the review is > > not making things like this require expert tuning.  If it is expected to > > be necessary, which Gallatin@ makes a case for, let’s toggle it on by > > default. > > > > On Mon, May 3, 2021 at 10:56 AM Mark Johnston > > wrote: > > > > The branch main has been updated by markj: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=64881da478071431a2d9e62613997a5772c56cdf > > > > > > commit 64881da478071431a2d9e62613997a5772c56cdf > > Author:     Sai Rajesh Tallamraju > > > > AuthorDate: 2021-05-03 17:45:00 +0000 > > Commit:     Mark Johnston > > CommitDate: 2021-05-03 17:47:14 +0000 > > > > It looks like AIM was on by default in 11.x and earlier: > hw.ix.enable_aim: 1 > hw.igb.enable_aim: 1 > > So I think enabling it does make sense in light of Drew's comments about > mbuf sorting only being useful in the face of something like AIM where > there will be a sufficient number of mbufs to sort. See https://reviews.freebsd.org/D30094