From owner-svn-src-all@freebsd.org Thu Dec 6 22:59:22 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8955213174E0; Thu, 6 Dec 2018 22:59:22 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 31350866E7; Thu, 6 Dec 2018 22:59:22 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 36A5A258E; Thu, 6 Dec 2018 22:59:19 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id wB6MxJm5026533; Thu, 6 Dec 2018 22:59:19 GMT (envelope-from imp@FreeBSD.org) Received: (from imp@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id wB6MxJ0x026532; Thu, 6 Dec 2018 22:59:19 GMT (envelope-from imp@FreeBSD.org) Message-Id: <201812062259.wB6MxJ0x026532@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org using -f From: Warner Losh Date: Thu, 6 Dec 2018 22:59:19 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r341661 - head/sbin/nvmecontrol/modules/intel X-SVN-Group: head X-SVN-Commit-Author: imp X-SVN-Commit-Paths: head/sbin/nvmecontrol/modules/intel X-SVN-Commit-Revision: 341661 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 31350866E7 X-Spamd-Result: default: False [-1.91 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-0.86)[-0.863,0]; NEURAL_HAM_SHORT(-0.97)[-0.969,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-0.08)[-0.083,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Dec 2018 22:59:22 -0000 Author: imp Date: Thu Dec 6 22:59:18 2018 New Revision: 341661 URL: https://svnweb.freebsd.org/changeset/base/341661 Log: It's useful to have this be a global function. Other vendors base their additional smart info pages on what Intel did plus some other bits. So it's convenient to have this be global. Sponsored by: Netflix Modified: head/sbin/nvmecontrol/modules/intel/intel.c Modified: head/sbin/nvmecontrol/modules/intel/intel.c ============================================================================== --- head/sbin/nvmecontrol/modules/intel/intel.c Thu Dec 6 22:59:08 2018 (r341660) +++ head/sbin/nvmecontrol/modules/intel/intel.c Thu Dec 6 22:59:18 2018 (r341661) @@ -119,7 +119,7 @@ print_intel_write_lat_log(const struct nvme_controller /* * Table 19. 5.4 SMART Attributes. Others also implement this and some extra data not documented. */ -static void +void print_intel_add_smart(const struct nvme_controller_data *cdata __unused, void *buf, uint32_t size __unused) { uint8_t *walker = buf;