From owner-freebsd-net@FreeBSD.ORG  Sat Mar 24 10:40:43 2007
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
X-Original-To: freebsd-net@FreeBSD.org
Delivered-To: freebsd-net@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 40F7816A403
	for <freebsd-net@FreeBSD.org>; Sat, 24 Mar 2007 10:40:43 +0000 (UTC)
	(envelope-from andre@freebsd.org)
Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2])
	by mx1.freebsd.org (Postfix) with ESMTP id A87D013C45E
	for <freebsd-net@FreeBSD.org>; Sat, 24 Mar 2007 10:40:42 +0000 (UTC)
	(envelope-from andre@freebsd.org)
Received: (qmail 74534 invoked from network); 24 Mar 2007 10:09:11 -0000
Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2])
	(envelope-sender <andre@freebsd.org>)
	by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP
	for <harti@freebsd.org>; 24 Mar 2007 10:09:11 -0000
Message-ID: <4604FDD4.2080805@freebsd.org>
Date: Sat, 24 Mar 2007 11:30:44 +0100
From: Andre Oppermann <andre@freebsd.org>
User-Agent: Thunderbird 1.5.0.10 (Windows/20070221)
MIME-Version: 1.0
To: Harti Brandt <harti@freebsd.org>
References: <200703231844.l2NIiCsa089542@freefall.freebsd.org>
	<20070324102948.Q58113@knop-beagle.kn.op.dlr.de>
In-Reply-To: <20070324102948.Q58113@knop-beagle.kn.op.dlr.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-net@FreeBSD.org, freebsd-bugs@FreeBSD.org
Subject: Re: kern/110720: [net] [patch] support for interface descriptions
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Mar 2007 10:40:43 -0000

Harti Brandt wrote:
> Nice feature, although it would be nice to align the maximum length with 
> IF-MIB::ifDescr (255 byte + \0). Also I suppose that the field more 
> naturally fits into struct if_data (see net/if.h) given the comment for 
> that struct:
> 
> /*
>  * Structure describing information about an interface
>  * which may be of interest to management entities.
>  */

The string array should most likely not be part of struct ifnet as that
would bloat it quite a bit.  If it is in there it should be at the end
of the struct to avoid cache line busting effects.

-- 
Andre