From owner-svn-src-all@FreeBSD.ORG  Fri Oct 24 18:47:02 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 733DAC45;
 Fri, 24 Oct 2014 18:47:02 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1DF05C9A;
 Fri, 24 Oct 2014 18:47:02 +0000 (UTC)
Received: from ralph.baldwin.cx (pool-173-70-85-31.nwrknj.fios.verizon.net
 [173.70.85.31])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 3959CB968;
 Fri, 24 Oct 2014 14:47:00 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Marcelo Araujo <araujo@freebsd.org>
Subject: Re: svn commit: r273576 - head/sys/dev/uart
Date: Fri, 24 Oct 2014 12:14:48 -0400
Message-ID: <235737869.CpTJALnJpW@ralph.baldwin.cx>
User-Agent: KMail/4.12.5 (FreeBSD/10.1-BETA2; KDE/4.12.5; amd64; ; )
In-Reply-To: <201410240539.s9O5dWWK002150@svn.freebsd.org>
References: <201410240539.s9O5dWWK002150@svn.freebsd.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 24 Oct 2014 14:47:00 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Oct 2014 18:47:02 -0000

On Friday, October 24, 2014 05:39:32 AM Marcelo Araujo wrote:
> Author: araujo (ports committer)
> Date: Fri Oct 24 05:39:32 2014
> New Revision: 273576
> URL: https://svnweb.freebsd.org/changeset/base/273576
> 
> Log:
>   Fix a leaked Storage Variable.
> 
>   Phabric:	D981
>   Submitted by:	myself
>   Reported by:	Coverity
>   CID:		1248848
>   Reworked by:	kevlo
>   Reviewed by:	marcel, davide, ray, kevlo
>   Approved by:	marcel, kevlo
> 
> Modified:
>   head/sys/dev/uart/uart_subr.c
> 
> Modified: head/sys/dev/uart/uart_subr.c
> ==============================================================================
> --- head/sys/dev/uart/uart_subr.c	Fri Oct 24 04:01:14 2014	(r273575)
> +++ head/sys/dev/uart/uart_subr.c	Fri Oct 24 05:39:32 2014	(r273576)
> @@ -196,7 +196,7 @@ out:
>  int
>  uart_getenv(int devtype, struct uart_devinfo *di, struct uart_class *class)
> {
> -	const char *spec;
> +	const char *cp, *spec;

Dropping const here is preferable to using __DECONST() for the freeenv() calls.

-- 
John Baldwin