From nobody Fri Oct 10 17:16:29 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cjtgx6wrYz6BckL; Fri, 10 Oct 2025 17:16:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cjtgx4Gj3z3gM8; Fri, 10 Oct 2025 17:16:29 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760116589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DfSDG/tbeYCw9eCAeGXEpByJseKsiEBdOVpSOyYYQQM=; b=BUX0GGd4TuTExYwBvJRaS+tPdyGepS4GhVt6Wv164FEXvasbT+qAN61QsC4FdYDO1BHUtp +r+Wjr+ZVOO+0WwzFPJ9XIG+52ofKObZmLewfh9IM5uClPVb9/olxOkmCh3DCp7RdIKqWd y7SpYgzIS9b0hpXG/qYbSFGSb5DasIXfe2389KSLpwuHs/zQikFu159NtVRkFajpeEdYTf C00ZkUiU8UKSNgJr1hl0orz6+//msluD2TMUYH+I0yCC/1YBQO0R5pLHrSW9ey2zcRD3XI LM4PDcc+H2VGlRREw/5JGMe4R7QdrhixU+iOXaHo1pb6JScuLYFGKeDPFSoCsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760116589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DfSDG/tbeYCw9eCAeGXEpByJseKsiEBdOVpSOyYYQQM=; b=uGaBblqn61uvaZnb3BWF817TugujzDU5eelfkb93v/18tBoahKGjpzHfLzM416O0OyX2FR L9Fpg3VqDkSE09lHOFay5++Cf2KjmNK4PeEMtL3GtCQ2WBbTebNtCwF6DzqRNr/eHoeb1Y /xA1j4bpeiUzgzTZnmhnUn7GhGIsKdlcO4oaGEK00ZnWNeDN+DhxZpymEwG8M5FImE7Chk 2mOYyXUigab5kFuZoHTffOReNZM7HeUrZXDoG0BkTQYM1yd1wPUnby3MkNAgAkksp5XM0o LkxT3Ry+KLJtHQps9ZrAO+R2F3mt9Nln0sxfO6Ebg7d/cTjwsTcQsmAd03nU9w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760116589; a=rsa-sha256; cv=none; b=dCJhZuuul0H9cqrVC9mIm99NO7pFX0mPVlJe9BWxPoyftSct0hs7S50Nx3tAQW+l4QQ7kE ciBWQaLlLlVnlSFBH8EyB0HVMOYu/yaWtraXf+ueeyTudKhhn2XSIP1EvCwGulBKsvygVY glzW7Kc/TXsM7PkzBLtfSrKope2k4t4j/sOxbxnCqnu4fCFST8s3YF8BgnftM9uf0LcRBd NgiYCIQXTA7mxt2T6SjnQMGRvtJKz5Ky3yumYX5jP8S+zAE/4bbccT7QmZMOYCDYEBxrRv 7OqZEwHqVRo+y44njSXqZFYK5gnAS5dxsmo9HKf3/yBuDRkb5lPX378Pjf/dJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cjtgx3pW5z1Br7; Fri, 10 Oct 2025 17:16:29 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59AHGTTR009492; Fri, 10 Oct 2025 17:16:29 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59AHGT7x009489; Fri, 10 Oct 2025 17:16:29 GMT (envelope-from git) Date: Fri, 10 Oct 2025 17:16:29 GMT Message-Id: <202510101716.59AHGT7x009489@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 3638aba1ceb9 - stable/14 - tools/regression/priv: Don't call setgroups() with the effective GID List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 3638aba1ceb99b8d687834af349fb73e33b1b0b3 Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=3638aba1ceb99b8d687834af349fb73e33b1b0b3 commit 3638aba1ceb99b8d687834af349fb73e33b1b0b3 Author: Olivier Certner AuthorDate: 2025-08-29 17:00:07 +0000 Commit: Olivier Certner CommitDate: 2025-10-10 17:15:59 +0000 tools/regression/priv: Don't call setgroups() with the effective GID The 'setgroups(0, NULL);' stance works the same on all versions of FreeBSD, getting rid of all supplementary groups. The replaced code would force the effective GID to also be a supplementary group. Fixes: 9da2fe96ff2e ("kern: fix setgroups(2) and getgroups(2) to match other platforms") MFC after: 5 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D52289 (cherry picked from commit ff7252cdafbd9dab104a5e7b33b8bb84117a8789) --- tools/regression/priv/main.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tools/regression/priv/main.c b/tools/regression/priv/main.c index dbcb5759f6b9..979e6ed65284 100644 --- a/tools/regression/priv/main.c +++ b/tools/regression/priv/main.c @@ -423,12 +423,10 @@ setup_file(const char *test, char *fpathp, uid_t uid, gid_t gid, mode_t mode) static void set_creds(const char *test, uid_t uid, gid_t gid) { - gid_t gids[1] = { gid }; - if (setgid(gid) < 0) err(-1, "test %s: setegid(%d)", test, gid); - if (setgroups(sizeof(gids)/sizeof(gid_t), gids) < 0) - err(-1, "test %s: setgroups(%d)", test, gid); + if (setgroups(0, NULL) < 0) + err(-1, "test %s: setgroups(NULL)", test); if (setuid(uid) < 0) err(-1, "test %s: seteuid(%d)", test, uid); }