From owner-svn-ports-head@FreeBSD.ORG Thu May 28 06:50:40 2015 Return-Path: Delivered-To: svn-ports-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 63F3F6E6; Thu, 28 May 2015 06:50:40 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from gw.catspoiler.org (unknown [IPv6:2001:4978:f:678::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 160A7139; Thu, 28 May 2015 06:50:39 +0000 (UTC) (envelope-from truckman@FreeBSD.org) Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2]) by gw.catspoiler.org (8.13.3/8.13.3) with ESMTP id t4S6oSd8066231; Wed, 27 May 2015 23:50:32 -0700 (PDT) (envelope-from truckman@FreeBSD.org) Message-Id: <201505280650.t4S6oSd8066231@gw.catspoiler.org> Date: Wed, 27 May 2015 23:50:28 -0700 (PDT) From: Don Lewis Subject: Re: svn commit: r387699 - in head/net/freerdp: . files To: jbeich@vfemail.net cc: ports-committers@FreeBSD.org, svn-ports-all@FreeBSD.org, svn-ports-head@FreeBSD.org In-Reply-To: MIME-Version: 1.0 Content-Type: TEXT/plain; charset=us-ascii X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 06:50:40 -0000 On 28 May, Jan Beich wrote: > Don Lewis writes: > >> Author: truckman >> Date: Thu May 28 04:46:15 2015 >> New Revision: 387699 >> URL: https://svnweb.freebsd.org/changeset/ports/387699 >> >> Log: >> Similar to r387391, zlib is also in base and there is no zlib.pc, so >> remove zlib from freerdp.pc and winpr.pc. Without this, net/vinagre >> still fails to configure. > > 10.1R and 11.0C have zlib.pc. > https://svnweb.freebsd.org/changeset/base/267376 Hmn ... yeah. I was afk for several days and on my return I saw all the net/vinagre pkg-fallout spam sent to gnome@, including for 10.1R. I assumed all the builds were failing for the same reason, but I see now that the 10.1R builds were failing because of the libssl problem that fixed by in r387391. Since zlib.pc isn't present in 8.4 and 9.3, we can't count on always being there. We either have to: 1) Never look for zlib.pc until 9.3 ie EOL (basically what commited). 2) Make the contents of freerdp.pc and winpr.pc depend on OSVERSION or the presence of zlib.pc. 3) Mark the port broken if zlib.pc is not present. The same applies to the other .pc files introduced after 9.3R.