From owner-svn-ports-head@FreeBSD.ORG  Wed Oct  9 21:58:00 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 34B318A0; Wed,  9 Oct 2013 21:58:00 +0000 (UTC)
Date: Wed, 9 Oct 2013 21:58:00 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Baptiste Daroussin <bapt@FreeBSD.org>
Subject: Re: svn commit: r329928 - head/sysutils/hoz/files
Message-ID: <20131009215800.GA50240@FreeBSD.org>
References: <201310092044.r99KiFUW017901@svn.freebsd.org>
 <20131009210116.GH95601@ithaqua.etoilebsd.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20131009210116.GH95601@ithaqua.etoilebsd.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 Jose Alonso Cardenas Marquez <acm@FreeBSD.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Oct 2013 21:58:00 -0000

On Wed, Oct 09, 2013 at 11:01:17PM +0200, Baptiste Daroussin wrote:
> On Wed, Oct 09, 2013 at 08:44:15PM +0000, Jose Alonso Cardenas Marquez wrote:
> > New Revision: 329928
> > URL: http://svnweb.freebsd.org/changeset/ports/329928
> > 
> > Log:
> >   - Respect CC
> >   
> > +@@ -1,17 +1,16 @@
> > + 
> > +-CC = gcc
> > ++CC ?= gcc
> > + 
> >   OBJ = hoz.o hozgtk.o hozgtk_c.o hozgtk_i.o hozgtk_s.o hozcli.o
> >   LINKOBJ  = hoz.o hozcli.o
> >   GLINKOBJ  = hoz.o hozgtk.o hozgtk_c.o hozgtk_i.o hozgtk_s.o
> 
> the right fix here is 
> MAKE_ARGS+=	CC="${CC}"
> 
> not to patch upstream makefile

In this case I think it's OK, since the patch was already there.  It's nice
to have all changes grouped together; plus, shall upstream decide to pull
our fixes, working with a patch is easier than to find MAKE_ARGS line some-
where in port's own Makefile.

./danfe