From owner-freebsd-bugs  Thu Jun  8 19:56:25 1995
Return-Path: bugs-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id TAA07864
          for bugs-outgoing; Thu, 8 Jun 1995 19:56:25 -0700
Received: from Root.COM (implode.Root.COM [198.145.90.1])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id TAA07858
          for <bugs@freebsd.org>; Thu, 8 Jun 1995 19:56:20 -0700
Received: from corbin.Root.COM (corbin.Root.COM [198.145.90.18]) by Root.COM (8.6.8/8.6.5) with ESMTP id TAA07583; Thu, 8 Jun 1995 19:59:39 -0700
Received: from localhost (localhost [127.0.0.1]) by corbin.Root.COM (8.6.11/8.6.5) with SMTP id TAA00249; Thu, 8 Jun 1995 19:56:33 -0700
Message-Id: <199506090256.TAA00249@corbin.Root.COM>
To: Matt Dillon <dillon@best.com>
cc: bugs@FreeBSD.org
Subject: Re: connect() bug found and fixed (uninitialized pointer) 
In-reply-to: Your message of "Thu, 08 Jun 95 19:16:58 -0701."
             <199506090217.TAA13416@shell1.best.com> 
From: David Greenman <davidg@Root.COM>
Reply-To: davidg@Root.COM
Date: Thu, 08 Jun 1995 19:56:32 -0700
Sender: bugs-owner@FreeBSD.org
Precedence: bulk

>    In case Dima didn't get this off to you, there's a bug in
>    netinet/tcp_usrreq.c: tcp_connect()... the ifaddr is left
>    uninitialized in the case where in_pcbladdr() fails.  The fix
>    is to check the error code from in_pcbladdr() and to return
>    it rather then fall through to the remaining code if it comes
>    back non-zero.
>
>    I stuck a printf() in there to catch the condition as well just to
>    see how often it occured... got about a hit every 10 minutes
>    on our (very busy) FTP/WWW server from ftpd.

   Interesting...I'll have a look. Want to send me a diff for how you think it
should be fixed?

>    Gotta quick question for you guys too:  Is it safe to create
>    UFS partitions greater then 2GB ?

   Yes. Walnut Creek's news server has a 9GB drive (w/single partition) for
it's spool/news, and has been working fine for a month or more.

-DG