From owner-svn-ports-head@freebsd.org  Thu Mar 30 03:34:32 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 23D9ED241D9;
 Thu, 30 Mar 2017 03:34:32 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 04F82121;
 Thu, 30 Mar 2017 03:34:32 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 4D78D14A5; Thu, 30 Mar 2017 03:34:31 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Matthew Rezny <rezny@freebsd.org>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
Subject: Re: svn commit: r437215 - in head/graphics: gbm libEGL libGL libglapi
References: <201703291657.v2TGvrpM076369@repo.freebsd.org>
 <h92c-ezt0-wny@FreeBSD.org> <1824022.AbFPd1OJUh@workstation.reztek>
Date: Thu, 30 Mar 2017 05:36:03 +0200
In-Reply-To: <1824022.AbFPd1OJUh@workstation.reztek> (Matthew Rezny's message
 of "Wed, 29 Mar 2017 21:56:52 +0200")
Message-ID: <8tnn-5tcs-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Mar 2017 03:34:32 -0000

Matthew Rezny <rezny@freebsd.org> writes:

> On Wednesday 29 March 2017 19:51:55 Jan Beich wrote:
>
>> Matthew Rezny <rezny@FreeBSD.org> writes:
>> > -	@${REINPLACE_CMD} -e 's|x86_64|amd64|' \
>> > +	@${REINPLACE_CMD} -e 's|x86_64|amd64|' -e 's|\\S\*//|[:space:]* //|' \
>> 
>> [:space:] is invalid character class thus treated as a list of characters.
>> \S corresponds to [^[:space:]], while \s to [[:space:]].
>> 
>>   $ man pcrepattern | col -b | fgrep -m1 \\S
>>            \S     any character that is not a white space character
>> 
>> This may break build given -march, etc. are no longer stripped.
>
> I wish that information had been presented when I said "I guess it should have 
> been [:space:] instead of [:graph:] in the replacement." after you stated 
> [:graph:] was plain incorrect, although it is what had been previously 
> suggested to me and did seem to be working.

I didn't focus on pointing out every mistake with the existing hack
because it was soon going away. Now that devel/libclc depends on llvm40
the original motivation to hold out on 17.* (bug 217016) before 2017Q2
has been weakened.

>
> To be sure there is no misunderstanding now, would you consider this correct?
> @${REINPLACE_CMD} -e 's|x86_64|amd64|' -e 's|\\S\*//|[^[:space:]]* //|' \

Not quite, adding extra space after [] is unnecessary.

  -e 's|\\S\*|[^[:space:]]*|' \