From owner-freebsd-net  Wed Aug 22 17:59:27 2001
Delivered-To: freebsd-net@freebsd.org
Received: from mail-out2.apple.com (mail-out2.apple.com [17.254.0.51])
	by hub.freebsd.org (Postfix) with ESMTP id 6971037B411
	for <freebsd-net@freebsd.org>; Wed, 22 Aug 2001 17:58:34 -0700 (PDT)
	(envelope-from zarzycki@freebsd.org)
Received: from apple.con (A17-128-100-225.apple.com [17.128.100.225])
	by mail-out2.apple.com (8.9.3/8.9.3) with ESMTP id RAA06418
	for <freebsd-net@freebsd.org>; Wed, 22 Aug 2001 17:58:33 -0700 (PDT)
Received: from scv1.apple.com (scv1.apple.com) by apple.con
 (Content Technologies SMTPRS 4.2.1) with ESMTP id <T5587d3710f118064e13a0@apple.con>;
 Wed, 22 Aug 2001 17:56:41 +0100
Received: from bonk.apple.com (bonk.apple.com [17.202.44.60])
	by scv1.apple.com (8.9.3/8.9.3) with ESMTP id RAA16024;
	Wed, 22 Aug 2001 17:58:33 -0700 (PDT)
Received: from localhost (zarzycki@localhost)
	by bonk.apple.com (8.11.2/8.11.2) with ESMTP id f7N0wW817712;
	Wed, 22 Aug 2001 17:58:33 -0700
X-Authentication-Warning: bonk.apple.com: zarzycki owned process doing -bs
Date: Wed, 22 Aug 2001 17:58:32 -0700 (PDT)
From: Dave Zarzycki <zarzycki@freebsd.org>
To: Mike Silbersack <silby@silby.com>
Cc: <freebsd-net@freebsd.org>
Subject: Re: RFC: SACK/FACK patch port to Current
In-Reply-To: <Pine.BSF.4.30.0108222028520.14763-100000@niwun.pair.com>
Message-ID: <Pine.LNX.4.33.0108221753470.17649-100000@bonk.apple.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org

On Wed, 22 Aug 2001, Mike Silbersack wrote:

> However, before that is done, I think some changes should be made; all the
> #ifdef SACK and #ifdef FACKs are ugly.  They should be taken out, and
> runtime tuneables (defaulting to on) should be added around the pieces of
> code that actually control SACK and FACK initialization at socket setup
> time.

I completely agree.

<excuse>
This was just a straight and very trivial port of the patch for
FreeBSD-4.3 that was posted here earlier this week.
</excuse>

> Once those changes are made, it's probably best to have 2-3 other
> committers test and review before committing.

Okay. Sounds fine to me.

davez

-- 
Dave Zarzycki
Darwin & Mac OS X
Apple Computer, Inc.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message