Date: Thu, 14 Dec 2023 10:50:34 -0700 From: Warner Losh <imp@bsdimp.com> To: Ronald Klop <ronald@freebsd.org> Cc: "freebsd-arm@freebsd.org" <freebsd-arm@freebsd.org> Subject: Re: initarm() parsing bootargs? Message-ID: <CANCZdfoMF6zgnqLc3sOKZgioy9TFH%2BEiRW4xGbakDMgkVwk-bA@mail.gmail.com> In-Reply-To: <ca0c5bc2-bb7a-4bbe-bf62-d41cced35bdf@FreeBSD.org> References: <881889965.11901.1702500020716@localhost> <ca0c5bc2-bb7a-4bbe-bf62-d41cced35bdf@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000004e41bc060c7bec57
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
On Thu, Dec 14, 2023 at 4:17=E2=80=AFAM Ronald Klop <ronald@freebsd.org> wr=
ote:
> Hi,
>
> I'm looking into some code but it is really early in the boot path so I
> find it hard to debug. Do you have some pointers?
>
> Booting my RPI it gets a parameter "bootargs" passed. I used this in a
> driver. See the forwarded email below for the details about this.
>
> But in sys/arm64/arm64/machdep_boot.c I found this code. It looks likes i=
t
> would nicely get and parse this "bootargs" which is called
> "linux_command_line" here.
>
> void
> parse_fdt_bootargs(void)
> {
>
> if (loader_envp =3D=3D NULL &&
> fdt_get_chosen_bootargs(linux_command_line,
> LBABI_MAX_COMMAND_LINE) =3D=3D 0) {
> init_static_kenv(static_kenv, sizeof(static_kenv));
> cmdline_set_env(linux_command_line, CMDLINE_GUARD);
> }
> }
>
> But kern_getenv() does not give me any values from this "bootargs" string=
.
>
> I started adding some printf() lines from initarm() up until this method
> but that is never printed. Is it too early in the boot to print anything?
> How do others debug these pieces of code?
>
You need EARLY_PRINTF defined. And maybe some more stuff as well. For
Allwinner, I could tell you how, but I see nothing in the devices that the
RPi uses. It most likely needs SOCDEV_PA and SOCDEV_VA assigned correctly.
I've never done early arg parsing.
But one thing you can do is to verify at runtime that the linux command
line is really there in the FDT exported from the kernel. RPi has weird
ways to pass stuff into the kernel historically, though I can't recall the
details beyond that.
Warner
> Regards,
> Ronald.
>
>
>
>
> -------- Forwarded Message --------
> Subject: Re: git: 3878bbf1bb9e - main - Teach if_smsc to get MAC
> from bootargs.
> Date: Wed, 13 Dec 2023 21:40:20 +0100 (CET)
> From: Ronald Klop <ronald-lists@klop.ws>
> To: Emmanuel Vadot <manu@bidouilliste.com>
> CC: Ronald Klop <ronald@FreeBSD.org>
>
>
>
> *Van:* Emmanuel Vadot <manu@bidouilliste.com>
> *Datum:* donderdag, 7 december 2023 14:35
> *Aan:* Ronald Klop <ronald@FreeBSD.org>
> *CC:* src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org,
> dev-commits-src-main@FreeBSD.org
> *Onderwerp:* Re: git: 3878bbf1bb9e - main - Teach if_smsc to get MAC from
> bootargs.
>
> On Thu, 7 Dec 2023 11:33:05 GMT
> Ronald Klop <ronald@FreeBSD.org> wrote:
>
> > The branch main has been updated by ronald:
> >
> > URL:
> https://cgit.FreeBSD.org/src/commit/?id=3D3878bbf1bb9e68f8579b57cde7d4e5c=
77de93320
> <
> https://cgit.FreeBSD.org/src/commit/?id=3D3878bbf1bb9e68f8579b57cde7d4e5c=
77de93320
> >
> >
> > commit 3878bbf1bb9e68f8579b57cde7d4e5c77de93320
> > Author: Ronald Klop <ronald@FreeBSD.org>
> > AuthorDate: 2023-11-04 14:14:00 +0000
> > Commit: Ronald Klop <ronald@FreeBSD.org>
> > CommitDate: 2023-12-07 11:32:01 +0000
> >
> > Teach if_smsc to get MAC from bootargs.
> >
> > Some Raspberry Pi pass smsc95xx.macaddr=3DXX:XX:XX:XX:XX:XX a=
s
> bootargs.
> > Use this if no ethernet address is found in an EEPROM.
> > As last resort fall back to ether_gen_addr() instead of rando=
m
> MAC.
> >
> > PR: 274092
> > Reported by: Patrick M. Hausen (via ML)
> > Reviewed by: imp, karels, zlei
> > Tested by: Patrick M. Hausen
> > Approved by: karels
> > MFC after: 1 month
> > Relnotes: yes
> > Differential Revision: https://reviews.freebsd.org/D42463 <
> https://reviews.freebsd.org/D42463>;
> > ---
> > sys/dev/usb/net/if_smsc.c | 86
> +++++++++++++++++++++++++++++++++++++++++++++--
> > sys/net/ethernet.h | 1 +
> > sys/net/if_ethersubr.c | 10 ++++--
> > 3 files changed, 92 insertions(+), 5 deletions(-)
> >
> > diff --git a/sys/dev/usb/net/if_smsc.c b/sys/dev/usb/net/if_smsc.=
c
> > index ec8197229f17..54b18e0a67c9 100644
> > --- a/sys/dev/usb/net/if_smsc.c
> > +++ b/sys/dev/usb/net/if_smsc.c
> > @@ -179,6 +179,8 @@ static const struct usb_device_id smsc_devs[]
> =3D {
> > #define ETHER_IS_VALID(addr) \
> > (!ETHER_IS_MULTICAST(addr) && !ETHER_IS_ZERO(addr))
> >
> > +#define BOOTARGS_SMSC95XX "smsc95xx.macaddr"
> > +
> > static device_probe_t smsc_probe;
> > static device_attach_t smsc_attach;
> > static device_detach_t smsc_detach;
> > @@ -1538,6 +1540,76 @@ smsc_ioctl(if_t ifp, u_long cmd, caddr_t
> data)
> > return (rc);
> > }
> >
> > +#ifdef FDT
> > +static bool
> > +smsc_get_smsc95xx_macaddr(char* bootargs, size_t len, struct
> usb_ether *ue)
> > +{
> > + int values[6];
> > + int i;
> > + char* p;
> > +
> > + p =3D strnstr(bootargs, BOOTARGS_SMSC95XX, len);
> > + if (p =3D=3D NULL)
> > + return (false);
> > +
> > + if (sscanf(p, BOOTARGS_SMSC95XX "=3D%x:%x:%x:%x:%x:%x%*c",
> > + &values[0], &values[1], &values[2],
> > + &values[3], &values[4], &values[5]) !=3D 6) {
> > + smsc_warn_printf((struct smsc_softc *)ue->ue_sc,
> > + "invalid mac from bootargs '%s'.\n", p);
> > + return (false);
> > + }
> > +
> > + for (i =3D 0; i < ETHER_ADDR_LEN; ++i)
> > + ue->ue_eaddr[i] =3D values[i];
> > +
> > + smsc_dbg_printf((struct smsc_softc *)ue->ue_sc,
> > + "bootargs mac=3D%6D.\n", ue->ue_eaddr, ":");
> > + return (true);
> > +}
> > +
> > +/**
> > + * Raspberry Pi is known to pass
> smsc95xx.macaddr=3DXX:XX:XX:XX:XX:XX via
> > + * bootargs.
> > + */
> > +static bool
> > +smsc_bootargs_get_mac_addr(device_t dev, struct usb_ether *ue)
> > +{
> > + char *bootargs;
> > + ssize_t len;
> > + phandle_t node;
> > +
> > + /* only use bootargs for the first device
> > + * to prevent duplicate mac addresses */
> > + if (device_get_unit(dev) !=3D 0)
> > + return (false);
> > + node =3D OF_finddevice("/chosen");
> > + if (node =3D=3D -1)
> > + return (false);
> > + if (OF_hasprop(node, "bootargs") =3D=3D 0) {
> > + smsc_dbg_printf((struct smsc_softc *)ue->ue_sc,
> > + "bootargs not found");
> > + return (false);
> > + }
> > + len =3D OF_getprop_alloc(node, "bootargs", (void **)&bootargs);
> > + if (len =3D=3D -1 || bootargs =3D=3D NULL) {
> > + smsc_warn_printf((struct smsc_softc *)ue->ue_sc,
> > + "failed alloc for bootargs (%lu)", len);
> > + return (false);
> > + }
>
> All this can be replaced with a call to fdt_get_chosen_bootargs.
> Also we already do this for arm and arm64 in machdep_boot.c and
> store
> the linux boot args in a static var called linux_command_line, maybe
> make it not static and get it from this driver.
> While you're at it make bcm2835_fbd.c and bcm2835_fb.c use this as
> they also get and parse the bootargs.
>
> Cheers,
>
> [...snip...]
>
> --
> Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
>
>
>
> Dear Emmanuel,
>
> I'm looking into this function fdt_get_chosen_bootargs. Unfortunately it
> uses static memory allocation which conflicts with another remark I got i=
n
> the review.
>
> But what I do see is that it parses this bootargs string into kern_setenv
> in sys/kern/subr_boot.c: boot_parse_arg(...).
> parse_fdt_bootargs (sys/arm64/arm64/machdep_boot.c) -> cmdline_set_env
> -> boot_parse_cmdline (subr_boot.c) -> boot_parse_cmdline_delim ->
> boot_parse_arg
> Would that be usable?
>
> I don't see the value in the output of kenv(1) but maybe that is not
> related.
>
> I'll try to come up with a testcase on my RPI to see if this bootargs end=
s
> up in kern_getenv in a parsed way.
>
> Regards,
> Ronald.
>
>
--0000000000004e41bc060c7bec57
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Thu, Dec 14, 2023 at 4:17=E2=80=AF=
AM Ronald Klop <<a href=3D"mailto:ronald@freebsd.org">ronald@freebsd.org=
</a>> wrote:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:=
0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">=
Hi,<br>
<br>
I'm looking into some code but it is really early in the boot path so I=
find it hard to debug. Do you have some pointers?<br>
<br>
Booting my RPI it gets a parameter "bootargs" passed. I used this=
in a driver. See the forwarded email below for the details about this.<br>
<br>
But in sys/arm64/arm64/machdep_boot.c I found this code. It looks likes it =
would nicely get and parse this "bootargs" which is called "=
linux_command_line" here.<br>
<br>
void<br>
parse_fdt_bootargs(void)<br>
{<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (loader_envp =3D=3D NULL && fd=
t_get_chosen_bootargs(linux_command_line,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0LBABI_MAX_COMMAND_LINE) =3D=
=3D 0) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0init_static_k=
env(static_kenv, sizeof(static_kenv));<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0cmdline_set_e=
nv(linux_command_line, CMDLINE_GUARD);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}<br>
}<br>
<br>
But kern_getenv() does not give me any values from this "bootargs"=
; string.<br>
<br>
I started adding some printf() lines from initarm() up until this method bu=
t that is never printed. Is it too early in the boot to print anything?<br>
How do others debug these pieces of code?<br></blockquote><div><br></div><d=
iv>You need EARLY_PRINTF defined. And maybe some more stuff as well. For Al=
lwinner, I could tell you how, but I see nothing in the devices that the RP=
i uses. It most likely needs SOCDEV_PA and SOCDEV_VA assigned correctly. I&=
#39;ve never done early arg parsing.</div><div><br></div><div>But one thing=
you can do is to verify at runtime that the linux command line is really t=
here in the FDT exported from the kernel. RPi has weird ways to pass stuff =
into the kernel historically, though I can't recall the details beyond =
that.</div><div><br></div><div>Warner</div><div>=C2=A0</div><blockquote cla=
ss=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid =
rgb(204,204,204);padding-left:1ex">
Regards,<br>
Ronald.<br>
<br>
<br>
<br>
<br>
-------- Forwarded Message --------<br>
Subject:=C2=A0 =C2=A0 =C2=A0 =C2=A0 Re: git: 3878bbf1bb9e - main - Teach if=
_smsc to get MAC from bootargs.<br>
Date:=C2=A0 =C2=A0Wed, 13 Dec 2023 21:40:20 +0100 (CET)<br>
From:=C2=A0 =C2=A0Ronald Klop <<a href=3D"mailto:ronald-lists@klop.ws" t=
arget=3D"_blank">ronald-lists@klop.ws</a>><br>
To:=C2=A0 =C2=A0 =C2=A0Emmanuel Vadot <<a href=3D"mailto:manu@bidouillis=
te.com" target=3D"_blank">manu@bidouilliste.com</a>><br>
CC:=C2=A0 =C2=A0 =C2=A0Ronald Klop <ronald@FreeBSD.org><br>
<br>
<br>
<br>
*Van:* Emmanuel Vadot <<a href=3D"mailto:manu@bidouilliste.com" target=
=3D"_blank">manu@bidouilliste.com</a>><br>
*Datum:* donderdag, 7 december 2023 14:35<br>
*Aan:* Ronald Klop <ronald@FreeBSD.org><br>
*CC:* src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-comm=
its-src-main@FreeBSD.org<br>
*Onderwerp:* Re: git: 3878bbf1bb9e - main - Teach if_smsc to get MAC from b=
ootargs.<br>
<br>
=C2=A0 =C2=A0 =C2=A0On Thu, 7 Dec 2023 11:33:05 GMT<br>
=C2=A0 =C2=A0 =C2=A0Ronald Klop <ronald@FreeBSD.org> wrote:<br>
<br>
=C2=A0 =C2=A0 =C2=A0 > The branch main has been updated by ronald:<br>
=C2=A0 =C2=A0 =C2=A0 ><br>
=C2=A0 =C2=A0 =C2=A0 > URL: <a href=3D"https://cgit.FreeBSD.org/src/comm=
it/?id=3D3878bbf1bb9e68f8579b57cde7d4e5c77de93320" rel=3D"noreferrer" targe=
t=3D"_blank">https://cgit.FreeBSD.org/src/commit/?id=3D3878bbf1bb9e68f8579b=
57cde7d4e5c77de93320</a> <<a href=3D"https://cgit.FreeBSD.org/src/commit=
/?id=3D3878bbf1bb9e68f8579b57cde7d4e5c77de93320" rel=3D"noreferrer" target=
=3D"_blank">https://cgit.FreeBSD.org/src/commit/?id=3D3878bbf1bb9e68f8579b5=
7cde7d4e5c77de93320</a>><br>
=C2=A0 =C2=A0 =C2=A0 ><br>
=C2=A0 =C2=A0 =C2=A0 > commit 3878bbf1bb9e68f8579b57cde7d4e5c77de93320<b=
r>
=C2=A0 =C2=A0 =C2=A0 > Author: =C2=A0=C2=A0=C2=A0=C2=A0Ronald Klop <r=
onald@FreeBSD.org><br>
=C2=A0 =C2=A0 =C2=A0 > AuthorDate: 2023-11-04 14:14:00 +0000<br>
=C2=A0 =C2=A0 =C2=A0 > Commit: =C2=A0=C2=A0=C2=A0=C2=A0Ronald Klop <r=
onald@FreeBSD.org><br>
=C2=A0 =C2=A0 =C2=A0 > CommitDate: 2023-12-07 11:32:01 +0000<br>
=C2=A0 =C2=A0 =C2=A0 ><br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0Teach if_smsc to get MAC =
from bootargs.<br>
=C2=A0 =C2=A0 =C2=A0 ><br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0Some Raspberry Pi pass sm=
sc95xx.macaddr=3DXX:XX:XX:XX:XX:XX as bootargs.<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0Use this if no ethernet a=
ddress is found in an EEPROM.<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0As last resort fall back =
to ether_gen_addr() instead of random MAC.<br>
=C2=A0 =C2=A0 =C2=A0 ><br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0PR: =C2=A0=C2=A0=C2=A0=C2=
=A0274092<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0Reported by: =C2=A0=C2=A0=
=C2=A0Patrick M. Hausen (via ML)<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0Reviewed by: =C2=A0=C2=A0=
=C2=A0imp, karels, zlei<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0Tested by: =C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0Patrick M. Hausen<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0Approved by: =C2=A0=C2=A0=
=C2=A0karels<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0MFC after: =C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A01 month<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0Relnotes: =C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0yes<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0Differential Revision: <a=
href=3D"https://reviews.freebsd.org/D42463" rel=3D"noreferrer" target=3D"_=
blank">https://reviews.freebsd.org/D42463</a>; <<a href=3D"https://review=
s.freebsd.org/D42463" rel=3D"noreferrer" target=3D"_blank">https://reviews.=
freebsd.org/D42463</a>><br>
=C2=A0 =C2=A0 =C2=A0 > ---<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0sys/dev/usb/net/if_smsc.c | 86 ++++++++++++=
+++++++++++++++++++++++++++++++++--<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0sys/net/ethernet.h =C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0| =C2=A01 +<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0sys/net/if_ethersubr.c =C2=A0=C2=A0=C2=A0| =
10 ++++--<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A03 files changed, 92 insertions(+), 5 deleti=
ons(-)<br>
=C2=A0 =C2=A0 =C2=A0 ><br>
=C2=A0 =C2=A0 =C2=A0 > diff --git a/sys/dev/usb/net/if_smsc.c b/sys/dev/=
usb/net/if_smsc.c<br>
=C2=A0 =C2=A0 =C2=A0 > index ec8197229f17..54b18e0a67c9 100644<br>
=C2=A0 =C2=A0 =C2=A0 > --- a/sys/dev/usb/net/if_smsc.c<br>
=C2=A0 =C2=A0 =C2=A0 > +++ b/sys/dev/usb/net/if_smsc.c<br>
=C2=A0 =C2=A0 =C2=A0 > @@ -179,6 +179,8 @@ static const struct usb_devic=
e_id smsc_devs[] =3D {<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0#define ETHER_IS_VALID(addr) \<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0(!ETHER_IS_MULTICAST(addr) &&=
!ETHER_IS_ZERO(addr))<br>
=C2=A0 =C2=A0 =C2=A0 ><br>
=C2=A0 =C2=A0 =C2=A0 > +#define BOOTARGS_SMSC95XX =C2=A0=C2=A0=C2=A0&quo=
t;smsc95xx.macaddr"<br>
=C2=A0 =C2=A0 =C2=A0 > +<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0static device_probe_t smsc_probe;<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0static device_attach_t smsc_attach;<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0static device_detach_t smsc_detach;<br>
=C2=A0 =C2=A0 =C2=A0 > @@ -1538,6 +1540,76 @@ smsc_ioctl(if_t ifp, u_lon=
g cmd, caddr_t data)<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0=C2=A0return (rc);<br>
=C2=A0 =C2=A0 =C2=A0 > =C2=A0}<br>
=C2=A0 =C2=A0 =C2=A0 ><br>
=C2=A0 =C2=A0 =C2=A0 > +#ifdef FDT<br>
=C2=A0 =C2=A0 =C2=A0 > +static bool<br>
=C2=A0 =C2=A0 =C2=A0 > +smsc_get_smsc95xx_macaddr(char* bootargs, size_t=
len, struct usb_ether *ue)<br>
=C2=A0 =C2=A0 =C2=A0 > +{<br>
=C2=A0 =C2=A0 =C2=A0 > + int values[6];<br>
=C2=A0 =C2=A0 =C2=A0 > + int i;<br>
=C2=A0 =C2=A0 =C2=A0 > + char* p;<br>
=C2=A0 =C2=A0 =C2=A0 > +<br>
=C2=A0 =C2=A0 =C2=A0 > + p =3D strnstr(bootargs, BOOTARGS_SMSC95XX, len)=
;<br>
=C2=A0 =C2=A0 =C2=A0 > + if (p =3D=3D NULL)<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0return (false);<br>
=C2=A0 =C2=A0 =C2=A0 > +<br>
=C2=A0 =C2=A0 =C2=A0 > + if (sscanf(p, BOOTARGS_SMSC95XX "=3D%x:%x:=
%x:%x:%x:%x%*c",<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0&values[0], &values[1], &values[2],<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0&values[3], &values[4], &values[5]) !=3D 6) {<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0smsc_warn_printf((struc=
t smsc_softc *)ue->ue_sc,<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0"invalid mac from bootargs '%s'.\n&=
quot;, p);<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0return (false);<br>
=C2=A0 =C2=A0 =C2=A0 > + }<br>
=C2=A0 =C2=A0 =C2=A0 > +<br>
=C2=A0 =C2=A0 =C2=A0 > + for (i =3D 0; i < ETHER_ADDR_LEN; ++i)<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0ue->ue_eaddr[i] =3D =
values[i];<br>
=C2=A0 =C2=A0 =C2=A0 > +<br>
=C2=A0 =C2=A0 =C2=A0 > + smsc_dbg_printf((struct smsc_softc *)ue->ue_=
sc,<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0"bootargs mac=3D%6D.\n", ue->ue_eaddr, ":");<br>
=C2=A0 =C2=A0 =C2=A0 > + return (true);<br>
=C2=A0 =C2=A0 =C2=A0 > +}<br>
=C2=A0 =C2=A0 =C2=A0 > +<br>
=C2=A0 =C2=A0 =C2=A0 > +/**<br>
=C2=A0 =C2=A0 =C2=A0 > + * Raspberry Pi is known to pass smsc95xx.macadd=
r=3DXX:XX:XX:XX:XX:XX via<br>
=C2=A0 =C2=A0 =C2=A0 > + * bootargs.<br>
=C2=A0 =C2=A0 =C2=A0 > + */<br>
=C2=A0 =C2=A0 =C2=A0 > +static bool<br>
=C2=A0 =C2=A0 =C2=A0 > +smsc_bootargs_get_mac_addr(device_t dev, struct =
usb_ether *ue)<br>
=C2=A0 =C2=A0 =C2=A0 > +{<br>
=C2=A0 =C2=A0 =C2=A0 > + char *bootargs;<br>
=C2=A0 =C2=A0 =C2=A0 > + ssize_t len;<br>
=C2=A0 =C2=A0 =C2=A0 > + phandle_t node;<br>
=C2=A0 =C2=A0 =C2=A0 > +<br>
=C2=A0 =C2=A0 =C2=A0 > + /* only use bootargs for the first device<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0* to prevent duplicate mac addresses */<b=
r>
=C2=A0 =C2=A0 =C2=A0 > + if (device_get_unit(dev) !=3D 0)<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0return (false);<br>
=C2=A0 =C2=A0 =C2=A0 > + node =3D OF_finddevice("/chosen");<br=
>
=C2=A0 =C2=A0 =C2=A0 > + if (node =3D=3D -1)<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0return (false);<br>
=C2=A0 =C2=A0 =C2=A0 > + if (OF_hasprop(node, "bootargs") =3D=
=3D 0) {<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0smsc_dbg_printf((struct=
smsc_softc *)ue->ue_sc,<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0"bootargs not found");<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0return (false);<br>
=C2=A0 =C2=A0 =C2=A0 > + }<br>
=C2=A0 =C2=A0 =C2=A0 > + len =3D OF_getprop_alloc(node, "bootargs&q=
uot;, (void **)&bootargs);<br>
=C2=A0 =C2=A0 =C2=A0 > + if (len =3D=3D -1 || bootargs =3D=3D NULL) {<br=
>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0smsc_warn_printf((struc=
t smsc_softc *)ue->ue_sc,<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0"failed alloc for bootargs (%lu)", len=
);<br>
=C2=A0 =C2=A0 =C2=A0 > + =C2=A0=C2=A0=C2=A0=C2=A0return (false);<br>
=C2=A0 =C2=A0 =C2=A0 > + }<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0All this can be replaced with a call to fdt_get_=
chosen_bootargs.<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0Also we already do this for arm and arm64 in mac=
hdep_boot.c and store<br>
=C2=A0 =C2=A0 =C2=A0the linux boot args in a static var called linux_comman=
d_line, maybe<br>
=C2=A0 =C2=A0 =C2=A0make it not static and get it from this driver.<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0While you're at it make bcm2835_fbd.c and bc=
m2835_fb.c use this as<br>
=C2=A0 =C2=A0 =C2=A0they also get and parse the bootargs.<br>
<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0Cheers,<br>
<br>
=C2=A0 =C2=A0 =C2=A0[...snip...]<br>
<br>
=C2=A0 =C2=A0 =C2=A0--<br>
=C2=A0 =C2=A0 =C2=A0Emmanuel Vadot <<a href=3D"mailto:manu@bidouilliste.=
com" target=3D"_blank">manu@bidouilliste.com</a>> <<a href=3D"mailto:=
manu@freebsd.org" target=3D"_blank">manu@freebsd.org</a>><br>
<br>
<br>
<br>
Dear Emmanuel,<br>
<br>
I'm looking into this function fdt_get_chosen_bootargs. Unfortunately i=
t uses static memory allocation which conflicts with another remark I got i=
n the review.<br>
<br>
But what I do see is that it parses this bootargs string into kern_setenv i=
n sys/kern/subr_boot.c: boot_parse_arg(...).<br>
parse_fdt_bootargs (sys/arm64/arm64/machdep_boot.c) ->=C2=A0cmdline_set_=
env ->=C2=A0boot_parse_cmdline (subr_boot.c) -> boot_parse_cmdline_de=
lim -> boot_parse_arg<br>
Would that be usable?<br>
<br>
I don't see the value in the output of kenv(1) but maybe that is not re=
lated.<br>
<br>
I'll try to come up with a testcase on my RPI to see if this bootargs e=
nds up in kern_getenv in a parsed way.<br>
<br>
Regards,<br>
Ronald.<br>
<br>
</blockquote></div></div>
--0000000000004e41bc060c7bec57--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoMF6zgnqLc3sOKZgioy9TFH%2BEiRW4xGbakDMgkVwk-bA>