From owner-svn-src-head@freebsd.org Tue Aug 11 05:37:57 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C92F837B3C0; Tue, 11 Aug 2020 05:37:57 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BQhSP2nySz43q2; Tue, 11 Aug 2020 05:37:57 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.16.1/8.16.1) with ESMTPS id 07B5boGK024796 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Mon, 10 Aug 2020 22:37:50 -0700 (PDT) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.16.1/8.16.1/Submit) id 07B5boHq024795; Mon, 10 Aug 2020 22:37:50 -0700 (PDT) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Mon, 10 Aug 2020 22:37:50 -0700 From: Gleb Smirnoff To: Hans Petter Selasky Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364072 - in head/sys: netinet netinet6 Message-ID: <20200811053750.GB1307@FreeBSD.org> References: <202008101040.07AAeK4e096973@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202008101040.07AAeK4e096973@repo.freebsd.org> X-Rspamd-Queue-Id: 4BQhSP2nySz43q2 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Aug 2020 05:37:57 -0000 Hans, On Mon, Aug 10, 2020 at 10:40:20AM +0000, Hans Petter Selasky wrote: H> Author: hselasky H> Date: Mon Aug 10 10:40:19 2020 H> New Revision: 364072 H> URL: https://svnweb.freebsd.org/changeset/base/364072 H> H> Log: H> Use proper prototype for SYSINIT() functions. H> Mark the unused argument using the __unused macro. H> H> Discussed with: kib@ H> MFC after: 1 week H> Sponsored by: Mellanox Technologies Why just do not use the SYSINIT at all? Index: in_mcast.c =================================================================== --- in_mcast.c (revision 364098) +++ in_mcast.c (working copy) @@ -229,17 +229,10 @@ inm_is_ifp_detached(const struct in_multi *inm) * dedicated thread to avoid deadlocks when draining inm_release tasks. */ TASKQUEUE_DEFINE_THREAD(inm_free); -static struct task inm_free_task; static struct in_multi_head inm_free_list = SLIST_HEAD_INITIALIZER(); static void inm_release_task(void *arg __unused, int pending __unused); +static struct task inm_free_task = TASK_INITIALIZER(0, inm_release_task, NULL); -static void -inm_init(void *arg __unused) -{ - TASK_INIT(&inm_free_task, 0, inm_release_task, NULL); -} -SYSINIT(inm_init, SI_SUB_TASKQ, SI_ORDER_ANY, inm_init, NULL); - void inm_release_wait(void *arg __unused) { Same for inm6. -- Gleb Smirnoff