Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 9 Jan 2020 19:56:25 +0000 (UTC)
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r356565 - stable/12/contrib/smbfs/lib/smb
Message-ID:  <202001091956.009JuPEO037317@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bapt
Date: Thu Jan  9 19:56:25 2020
New Revision: 356565
URL: https://svnweb.freebsd.org/changeset/base/356565

Log:
  MFC r356317 (by arrowd):
  
  mount_smbfs: Issue a warning when .nsmbrc section name contains lowercase characters.
  
  PR:  231656
  Approved by: bapt
  Differential Revision: https://reviews.freebsd.org/D22289

Modified:
  stable/12/contrib/smbfs/lib/smb/rcfile.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/contrib/smbfs/lib/smb/rcfile.c
==============================================================================
--- stable/12/contrib/smbfs/lib/smb/rcfile.c	Thu Jan  9 19:22:11 2020	(r356564)
+++ stable/12/contrib/smbfs/lib/smb/rcfile.c	Thu Jan  9 19:56:25 2020	(r356565)
@@ -156,11 +156,19 @@ static struct rcsection *
 rc_addsect(struct rcfile *rcp, const char *sectname)
 {
 	struct rcsection *p;
+	const char* sectletter = sectname;
 
 	p = rc_findsect(rcp, sectname);
 	if (p) return p;
 	p = malloc(sizeof(*p));
 	if (!p) return NULL;
+	for(sectletter = sectname; *sectletter; sectletter++) {
+		if (islower(*sectletter)) {
+			if (strcmp(sectname, "default"))
+				dprintf(STDERR_FILENO, "warning: section name [%s] contains lower-case letters\n", sectname);
+			break;
+		}
+	}
 	p->rs_name = strdup(sectname);
 	SLIST_INIT(&p->rs_keys);
 	SLIST_INSERT_HEAD(&rcp->rf_sect, p, rs_next);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202001091956.009JuPEO037317>