From owner-freebsd-current Mon Nov 29 15:36:22 1999 Delivered-To: freebsd-current@freebsd.org Received: from assurance.rstcorp.com (assurance.rstcorp.com [216.112.242.2]) by hub.freebsd.org (Postfix) with ESMTP id 09B6E14BC4 for ; Mon, 29 Nov 1999 15:36:19 -0800 (PST) (envelope-from vshah@rstcorp.com) Received: (from uucp@localhost) by assurance.rstcorp.com (8.8.8/8.8.8) id SAA01182; Mon, 29 Nov 1999 18:37:40 -0500 Received: from proxy.rstcorp.com(216.112.242.5) by assurance.rstcorp.com via smap (V2.0) id xma001173; Mon, 29 Nov 99 23:37:07 GMT Received: from jabberwock.rstcorp.com (jabberwock.rstcorp.com [192.168.2.98]) by sandbox.rstcorp.com (8.8.8+Sun/8.8.8) with ESMTP id SAA01602; Mon, 29 Nov 1999 18:33:17 -0500 (EST) Received: by jabberwock.rstcorp.com (Postfix, from userid 93) id 482B35AF0; Mon, 29 Nov 1999 18:35:41 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <14403.3532.973553.40985@jabberwock.rstcorp.com> Date: Mon, 29 Nov 1999 18:35:40 -0500 (EST) From: "Viren R.Shah" To: Matthew Dillon Cc: freebsd-current@FreeBSD.org Subject: Re: repeatable crash in -current (softupdates, NFS) In-Reply-To: <199911292325.PAA12356@apollo.backplane.com> References: <14399.63511.296802.242618@jabberwock.rstcorp.com> <19991127191729.A53832@bitbox.follo.net> <14402.62122.461010.454021@jabberwock.rstcorp.com> <199911292152.NAA09656@apollo.backplane.com> <19991129235631.P60031@bitbox.follo.net> <199911292308.PAA12218@apollo.backplane.com> <19991130001724.S60031@bitbox.follo.net> <199911292325.PAA12356@apollo.backplane.com> X-Mailer: VM 6.72 under 19.16 "Lille" XEmacs Lucid Reply-To: "Viren R.Shah" X-Face: )~y+U*K:yzjz{q<5lzpI_SVef'U.])9g[C9`1N@]u3,MHY7f*l7C)[_NjM4y4K8$uIUh|\u (K&&HS6,M!61&GMTk'mqmB/Qg]]X}"?TzsFl]"2v!bl8']dma.:^IY^a[lbOI>U:b<~FyK3q-p{HmZ mn~g.`~BE!5{2D:}Yi+\_KkWe?XaHj9$ko1k8iKLYv5*_2c8"G=?Up[}hn+7RNM(bzBZ_wWk6!Pf&B ?3Tcm7M7B~W%K/I0aX3]*=jP?aM]H6HBPT`oLk+0n^_;N\2\%|Rhy;p}34Q.jEsM\qtnxcm;ag%Nq Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG >>>>> "Matt" == Matthew Dillon writes: Matt> I've added a little cleanup to this patch. Viren, please try this Matt> patch. Matt> -Matt Matt> Matthew Dillon Matt> Matt> Index: nfs_vnops.c Matt> =================================================================== Matt> RCS file: /FreeBSD/FreeBSD-CVS/src/sys/nfs/nfs_vnops.c,v Matt> retrieving revision 1.146 Matt> diff -u -r1.146 nfs_vnops.c Matt> --- nfs_vnops.c 1999/11/27 18:14:41 1.146 Matt> +++ nfs_vnops.c 1999/11/29 23:23:05 Matt> @@ -1806,11 +1806,10 @@ Matt> txdr_nfsv2time(&vap->va_mtime, &sp->sa_mtime); Matt> } Matt> nfsm_request(dvp, NFSPROC_SYMLINK, cnp->cn_proc, cnp->cn_cred); Matt> - if (v3) { Matt> - if (!error) Matt> - nfsm_mtofh(dvp, newvp, v3, gotvp); Matt> + if (!error) Matt> + nfsm_mtofh(dvp, newvp, v3, gotvp); ^^^^^^^^^^ Should that still be "v3"? Since you moved it out of the "if (v3)" block, sholudn't it say something else? Viren -- Viren Shah | "You can't trust code that you did not totally Research Associate, RST Inc. | create yourself. (Especially code from viren@rstcorp.com | companies that employ people like me.)" http://www.rstcorp.com/~vshah | - Ken Thompson "Reflections on Trusting Trust" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message