From owner-freebsd-hackers@FreeBSD.ORG Fri Jun 9 13:50:02 2006 Return-Path: X-Original-To: freebsd-hackers@FreeBSD.ORG Delivered-To: freebsd-hackers@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6036D16A41A for ; Fri, 9 Jun 2006 13:50:02 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id D24AD43D70 for ; Fri, 9 Jun 2006 13:50:01 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost.village.org [IPv6:::1] (may be forged)) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k59DmZDx052854; Fri, 9 Jun 2006 07:48:37 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Fri, 09 Jun 2006 07:48:44 -0600 (MDT) Message-Id: <20060609.074844.1324583587.imp@bsdimp.com> To: jeremie@le-hen.org From: "M. Warner Losh" In-Reply-To: <20060609094052.GH1273@obiwan.tataz.chchile.org> References: <20060609094052.GH1273@obiwan.tataz.chchile.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-hackers@FreeBSD.ORG Subject: Re: How to disable a src.conf on command-line X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Jun 2006 13:50:02 -0000 In message: <20060609094052.GH1273@obiwan.tataz.chchile.org> Jeremie Le Hen writes: : (My concern is about activation of stack-smashing protection compiler : options. I'd like the user to be able to use -DWITHOUT_SSP to : compile something, even if he has WITH_SSP=YES in src.conf(5). : Should I turn the name of this options into ENABLE_SSP and pull it : out the bsd.own.mk magic ?) First, there's the trick: make -V MK_FOO if you are unsure of the results. For make options that default to enabled, turning them off in one place (command line or src.conf) will turn them off. Likewise for on. So if you make WITH_SSP off by default, then having WITH_SSP in the src.conf can't be overridden. If you have it on by default, having WITHOUT_SSP in the src.conf file can't be overriden. this appears to be an unintended flaw with the with/without stuff. I'm not sure the right way to compensate. Finally, please don't invent another way to configure the system. Many code reviewers will not like you much for doing that, since we've recently worked hard to make them all regular. If you need to do something the current scheme doesn't allow, we need to expand the current scheme somehow. Warner