Date: Sat, 13 Aug 2016 10:12:58 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-approval requested: [Bug 211684] audio/pulseaudio: Respect hw.snd.default_unit : [Attachment 173625] Proposed patch (since 419133 revision) for v8.0 Message-ID: <bug-211684-6497-TaZjCYKTV0@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-211684-6497@https.bugs.freebsd.org/bugzilla/> References: <bug-211684-6497@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
lightside <lightside@gmx.com> has asked gnome@FreeBSD.org for maintainer-approval: Bug 211684: audio/pulseaudio: Respect hw.snd.default_unit https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D211684 Attachment 173625: Proposed patch (since 419133 revision) for v8.0 https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D173625&action=3Dedit --- Comment #11 from lightside <lightside@gmx.com> --- Created attachment 173625 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D173625&action= =3Dedit Proposed patch (since 419133 revision) for v8.0 I changed parsing algorithm to find last occurrence of '>' character, which= may exclude (possible) usage of "> (" along with "play" or "rec" words in device name. This conforms to current format of output in sndstat source code: on FreeBSD: https://github.com/freebsd/freebsd/blob/4a8d8f7fba6ae0abcfae7ee40db2bcf9b56= 3fe0 1/sys/dev/sound/pcm/sndstat.c#L361 https://github.com/freebsd/freebsd/blob/4a8d8f7fba6ae0abcfae7ee40db2bcf9b56= 3fe0 1/sys/dev/sound/pcm/sndstat.h#L49 and DragonFlyBSD: https://github.com/DragonFlyBSD/DragonFlyBSD/blob/d78ce965185bbe24349ec52ee= b17e 712b8a0d8dc/sys/dev/sound/pcm/sndstat.c#L399 https://github.com/DragonFlyBSD/DragonFlyBSD/blob/d78ce965185bbe24349ec52ee= b17e 712b8a0d8dc/sys/dev/sound/pcm/sndstat.h#L49
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211684-6497-TaZjCYKTV0>