From owner-freebsd-hackers Wed Sep 20 11:15:49 2000 Delivered-To: freebsd-hackers@freebsd.org Received: from cs.huji.ac.il (cs.huji.ac.il [132.65.16.10]) by hub.freebsd.org (Postfix) with ESMTP id 35BAA37B424; Wed, 20 Sep 2000 11:15:44 -0700 (PDT) Received: from sexta.cs.huji.ac.il ([132.65.16.13] ident=exim) by cs.huji.ac.il with esmtp (Exim 3.15 #1) id 13boP0-0003yP-00; Wed, 20 Sep 2000 21:15:26 +0300 Received: from localhost ([127.0.0.1] helo=sexta.cs.huji.ac.il ident=danny) by sexta.cs.huji.ac.il with esmtp (Exim 3.15 #1) id 13boOy-0001Sj-00; Wed, 20 Sep 2000 21:15:24 +0300 X-Mailer: exmh version 2.2 06/23/2000 with nmh-0.24 To: Paul Saab Cc: Matt Dillon , Mike Smith , freebsd-hackers@FreeBSD.ORG Subject: Re: diskless workstation In-reply-to: Your message of Wed, 20 Sep 2000 11:07:44 -0700 . Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 20 Sep 2000 21:15:24 +0300 From: Danny Braniss Message-Id: Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20000920110744.A55357@elvis.mu.org>you write: }Matt Dillon (dillon@earth.backplane.com) wrote: }> A quick review of the code seems to indicate that this is indeed a bug. }> As far as I can tell, the IN_CLASS*() macros assume host order. e.g. }> from /usr/include/netinet/in.h: }> }> #define IN_CLASSA(i) (((u_int32_t)(i) & 0x80000000) == 0) }> }> Since s_addr is in network byte order, the conversion is necessary. If }> this fixes Danny's problems, and doesn't break anyone else (Paul?), I'd }> say it should be committed. } }After playing with it somemore, I agree.. It doesn't break for small }networks, which is what I was testing on. I'll commit the fix. } i still think that this part of code is useless. why overwride the info supplied by dhcp? if it's wrong then the dhcpd.conf should be fixed or some message printed. at the moment, bootp silently ignores some info it conciders wrong - wrongly :-) danny }paul } To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message