From owner-freebsd-bugs Sat Jun 14 01:30:03 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.5/8.8.5) id BAA13829 for bugs-outgoing; Sat, 14 Jun 1997 01:30:03 -0700 (PDT) Received: (from gnats@localhost) by hub.freebsd.org (8.8.5/8.8.5) id BAA13818; Sat, 14 Jun 1997 01:30:01 -0700 (PDT) Resent-Date: Sat, 14 Jun 1997 01:30:01 -0700 (PDT) Resent-Message-Id: <199706140830.BAA13818@hub.freebsd.org> Resent-From: gnats (GNATS Management) Resent-To: freebsd-bugs Resent-Reply-To: FreeBSD-gnats@FreeBSD.ORG, dima@tejblum.dnttm.rssi.ru Received: from helios.dnttm.ru (uutejb@[194.85.104.197]) by hub.freebsd.org (8.8.5/8.8.5) with ESMTP id BAA13626 for ; Sat, 14 Jun 1997 01:25:19 -0700 (PDT) Received: (from uutejb@localhost) by helios.dnttm.ru (8.8.5/8.8.5/IP-3) with UUCP id MAA16798 for FreeBSD-gnats-submit@freebsd.org; Sat, 14 Jun 1997 12:26:48 +0400 Received: (from dima@localhost) by tejblum.dnttm.rssi.ru (8.8.5/8.8.5) id MAA00728; Sat, 14 Jun 1997 12:17:47 +0400 (MSD) Message-Id: <199706140817.MAA00728@tejblum.dnttm.rssi.ru> Date: Sat, 14 Jun 1997 12:17:47 +0400 (MSD) From: Dmitrij Tejblum Reply-To: dima@tejblum.dnttm.rssi.ru To: FreeBSD-gnats-submit@FreeBSD.ORG X-Send-Pr-Version: 3.2 Subject: bin/3864: Incorrect usage of err(3) in mount_union.c Sender: owner-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >Number: 3864 >Category: bin >Synopsis: Incorrect usage of err(3) in mount_union.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Jun 14 01:30:01 PDT 1997 >Last-Modified: >Originator: Dmitrij Tejblum >Organization: >Release: FreeBSD 3.0-CURRENT i386 >Environment: >Description: When mount() system call in mount_union.c fails, it call err(EX_OSERR, target). It is incorrect. First, target may contain '%'... Second, the error may be related to source, not to target (for example, "No such file or directory"). >How-To-Repeat: dima@tejblum|/usr/home/dima>mount_union a%d b%d mount_union: /usr/home/dima/a-272639828: No such file or directory dima@tejblum|/usr/home/dima>mkdir misc dima@tejblum|/usr/home/dima>mount_union misc b%d mount_union: /usr/home/dima/misc: No such file or directory dima@tejblum|/usr/home/dima> >Fix: *** /usr/src/sbin/mount_union/mount_union.c Sun May 25 12:18:27 1997 --- mount_union.c Sat Jun 14 11:44:06 1997 *************** *** 127,133 **** errx(EX_OSERR, "union filesystem is not available"); if (mount(vfc.vfc_name, source, mntflags, &args)) ! err(EX_OSERR, target); exit(0); } --- 127,133 ---- errx(EX_OSERR, "union filesystem is not available"); if (mount(vfc.vfc_name, source, mntflags, &args)) ! err(EX_OSERR, NULL); exit(0); } >Audit-Trail: >Unformatted: