From owner-cvs-gnu  Fri Jun 21 23:32:50 1996
Return-Path: owner-cvs-gnu
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id XAA04122
          for cvs-gnu-outgoing; Fri, 21 Jun 1996 23:32:50 -0700 (PDT)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id XAA04116;
          Fri, 21 Jun 1996 23:32:45 -0700 (PDT)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id QAA21238; Sat, 22 Jun 1996 16:29:17 +1000
Date: Sat, 22 Jun 1996 16:29:17 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199606220629.QAA21238@godzilla.zeta.org.au>
To: CVS-committers@freefall.freebsd.org, ache@freefall.freebsd.org,
        cvs-all@freefall.freebsd.org, cvs-gnu@freefall.freebsd.org
Subject: Re: cvs commit:  src/gnu/usr.bin/man/man Makefile man.c
Sender: owner-cvs-gnu@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

>  Modified:    gnu/usr.bin/man/man  Makefile man.c
>  Log:
>  Close security holes and restore suid bit
>  Restore writting cat's functionality

>  Revision  Changes    Path
>  1.16      +2 -0      src/gnu/usr.bin/man/man/Makefile
>  1.15      +123 -46   src/gnu/usr.bin/man/man/man.c

This should have been reviewed.  I found a bug easily:

$ man -d ls
[Nothing interestting]
$ su
# mkdir /usr/share/man/cat1	# I don't have cat directories
# chown man /usr/share/man/cat1
# exit
$ man -d ls
[Nothing interesting]
$ man ls
zcat: /usr/share/man/cat1/ls.1.gz: unexpected end of file
[file is 0 bytes long]

The old version built the cat file normally even in the debugging case.

Bruce