From owner-dev-commits-src-all@freebsd.org  Fri Jan  8 05:09:40 2021
Return-Path: <owner-dev-commits-src-all@freebsd.org>
Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id DB75F4E6492;
 Fri,  8 Jan 2021 05:09:40 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DBrkX5vc3z4tg7;
 Fri,  8 Jan 2021 05:09:40 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-ua1-f46.google.com (mail-ua1-f46.google.com
 [209.85.222.46])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id B7B982C721;
 Fri,  8 Jan 2021 05:09:40 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-ua1-f46.google.com with SMTP id n18so3057645ual.9;
 Thu, 07 Jan 2021 21:09:40 -0800 (PST)
X-Gm-Message-State: AOAM5307EnKrZSriDqnT2uY/KdbQy12WZKkP87guWbdbjBmDxuXH8Y2+
 ceIbx8jiqLqs/ugDMI7uDVyBpj/Xxn5btCYuCF8=
X-Google-Smtp-Source: ABdhPJyYiNYzxodNYHHc8XoB/ptOELuqDmPPPskUMBEupiMNqd8FZ3lA66s71DjIgvi0g9IlydVWsft7ggXRgz6sfHQ=
X-Received: by 2002:ab0:708c:: with SMTP id m12mr1641703ual.69.1610082580302; 
 Thu, 07 Jan 2021 21:09:40 -0800 (PST)
MIME-Version: 1.0
References: <202101080502.10852ubl010373@gitrepo.freebsd.org>
In-Reply-To: <202101080502.10852ubl010373@gitrepo.freebsd.org>
From: Kyle Evans <kevans@freebsd.org>
Date: Thu, 7 Jan 2021 23:09:29 -0600
X-Gmail-Original-Message-ID: <CACNAnaEEGZJF3U0GZ5aSYTib1EgaVAFSU97637S_KexR3izORg@mail.gmail.com>
Message-ID: <CACNAnaEEGZJF3U0GZ5aSYTib1EgaVAFSU97637S_KexR3izORg@mail.gmail.com>
Subject: Re: git: da3ef8e66aa1 - main - Fix conflicting value of O_DSYNC.
To: Thomas Munro <tmunro@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>,
 dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev-commits-src-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the src repository
 <dev-commits-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-all/>
List-Post: <mailto:dev-commits-src-all@freebsd.org>
List-Help: <mailto:dev-commits-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-all>, 
 <mailto:dev-commits-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Jan 2021 05:09:40 -0000

On Thu, Jan 7, 2021 at 11:03 PM Thomas Munro <tmunro@freebsd.org> wrote:
>
> The branch main has been updated by tmunro:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=da3ef8e66aa13db9a79841127a3cbf067de41b69
>
> commit da3ef8e66aa13db9a79841127a3cbf067de41b69
> Author:     Thomas Munro <tmunro@FreeBSD.org>
> AuthorDate: 2021-01-08 05:01:15 +0000
> Commit:     Thomas Munro <tmunro@FreeBSD.org>
> CommitDate: 2021-01-08 05:01:15 +0000
>
>     Fix conflicting value of O_DSYNC.
>
>     O_RESOLVE_BENEATH recently took value 0x00800000, but I failed to spot
>     that while rebasing.  Let's use 0x01000000 for the new O_DSYNC flag.
>
>     Reported by: kevans
>

Thanks! I wouldn't have spotted it, except I have a local patchset
that I did the exact same thing on when rebasing across
O_RESOLVE_BENEATH. :-)