From owner-svn-src-all@FreeBSD.ORG Fri Mar 20 18:35:16 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 83D1410656C3; Fri, 20 Mar 2009 18:35:16 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 7152D8FC1C; Fri, 20 Mar 2009 18:35:16 +0000 (UTC) (envelope-from rnoland@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n2KIZGfm010429; Fri, 20 Mar 2009 18:35:16 GMT (envelope-from rnoland@svn.freebsd.org) Received: (from rnoland@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n2KIZGxf010428; Fri, 20 Mar 2009 18:35:16 GMT (envelope-from rnoland@svn.freebsd.org) Message-Id: <200903201835.n2KIZGxf010428@svn.freebsd.org> From: Robert Noland Date: Fri, 20 Mar 2009 18:35:16 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r190170 - head/sys/dev/drm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2009 18:35:17 -0000 Author: rnoland Date: Fri Mar 20 18:35:16 2009 New Revision: 190170 URL: http://svn.freebsd.org/changeset/base/190170 Log: vm_offset_t is unsigned, so compare of >= 0 is not needed. Found with: Coverity Prevent(tm) CID: 2259 MFC after: 3 days Modified: head/sys/dev/drm/drm_vm.c Modified: head/sys/dev/drm/drm_vm.c ============================================================================== --- head/sys/dev/drm/drm_vm.c Fri Mar 20 18:30:20 2009 (r190169) +++ head/sys/dev/drm/drm_vm.c Fri Mar 20 18:35:16 2009 (r190170) @@ -54,7 +54,7 @@ int drm_mmap(struct cdev *kdev, vm_offse if (file_priv && !file_priv->authenticated) return EACCES; - if (dev->dma && offset >= 0 && offset < ptoa(dev->dma->page_count)) { + if (dev->dma && offset < ptoa(dev->dma->page_count)) { drm_device_dma_t *dma = dev->dma; DRM_SPINLOCK(&dev->dma_lock);