From owner-svn-ports-head@freebsd.org Thu Mar 30 03:53:37 2017 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A1C26D24FA7; Thu, 30 Mar 2017 03:53:37 +0000 (UTC) (envelope-from jmd@freebsd.org) Received: from www.poelloepaeae.de (www.poelloepaeae.de [95.170.95.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 680D7181; Thu, 30 Mar 2017 03:53:37 +0000 (UTC) (envelope-from jmd@freebsd.org) Received: from www.poelloepaeae.de (www.poelloepaeae.de [192.168.1.105]) by www.poelloepaeae.de (Postfix) with ESMTP id 0185A50703; Thu, 30 Mar 2017 05:48:17 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 29 Mar 2017 23:48:17 -0400 From: Johannes M Dieterich To: Jan Beich Cc: Matthew Rezny , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, owner-ports-committers@freebsd.org Subject: Re: svn commit: r437215 - in head/graphics: gbm libEGL libGL libglapi Organization: FreeBSD - ports In-Reply-To: <8tnn-5tcs-wny@FreeBSD.org> References: <201703291657.v2TGvrpM076369@repo.freebsd.org> <1824022.AbFPd1OJUh@workstation.reztek> <8tnn-5tcs-wny@FreeBSD.org> Message-ID: <6a245317c900f4cf092bcdf70c1798ee@freebsd.org> X-Sender: jmd@freebsd.org User-Agent: Roundcube Webmail/1.2.3 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 03:53:37 -0000 On 2017-03-29 23:36, Jan Beich wrote: > Matthew Rezny writes: > >> On Wednesday 29 March 2017 19:51:55 Jan Beich wrote: >> >>> Matthew Rezny writes: >>> > - @${REINPLACE_CMD} -e 's|x86_64|amd64|' \ >>> > + @${REINPLACE_CMD} -e 's|x86_64|amd64|' -e 's|\\S\*//|[:space:]* //|' \ >>> >>> [:space:] is invalid character class thus treated as a list of >>> characters. >>> \S corresponds to [^[:space:]], while \s to [[:space:]]. >>> >>> $ man pcrepattern | col -b | fgrep -m1 \\S >>> \S any character that is not a white space character >>> >>> This may break build given -march, etc. are no longer stripped. >> >> I wish that information had been presented when I said "I guess it >> should have >> been [:space:] instead of [:graph:] in the replacement." after you >> stated >> [:graph:] was plain incorrect, although it is what had been previously >> suggested to me and did seem to be working. > > I didn't focus on pointing out every mistake with the existing hack > because it was soon going away. Now that devel/libclc depends on llvm40 > the original motivation to hold out on 17.* (bug 217016) before 2017Q2 > has been weakened. Also, there is a review for 17.0.2 up by me: https://reviews.freebsd.org/D9469 which changes the default LLVM version to 4.0 as newer AMD GPUs need that and uses libudev-devd now. Comments welcome! Please note that after today's commits the patch will not apply cleanly anymore, I'll update. >> To be sure there is no misunderstanding now, would you consider this >> correct? >> @${REINPLACE_CMD} -e 's|x86_64|amd64|' -e 's|\\S\*//|[^[:space:]]* >> //|' \ > > Not quite, adding extra space after [] is unnecessary. > > -e 's|\\S\*|[^[:space:]]*|' \