From owner-cvs-all Sat Mar 23 11:39:38 2002 Delivered-To: cvs-all@freebsd.org Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169]) by hub.freebsd.org (Postfix) with ESMTP id 99B0437B400; Sat, 23 Mar 2002 11:39:31 -0800 (PST) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by dragon.nuxi.com (8.12.2/8.12.2) with ESMTP id g2NJdUYm088221; Sat, 23 Mar 2002 11:39:30 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.12.2/8.12.2/Submit) id g2NJcEnH088198; Sat, 23 Mar 2002 11:38:14 -0800 (PST) Date: Sat, 23 Mar 2002 11:38:14 -0800 From: "David O'Brien" To: Bruce Evans Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/msun/bsdsrc b_exp.c b_log.c b_tgamma.c Message-ID: <20020323113814.C82167@dragon.nuxi.com> Reply-To: obrien@FreeBSD.org References: <20020321232232.A21049@dragon.nuxi.com> <20020323120137.T20431-100000@gamplex.bde.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20020323120137.T20431-100000@gamplex.bde.org>; from bde@zeta.org.au on Sat, Mar 23, 2002 at 12:03:05PM +1100 X-Operating-System: FreeBSD 5.0-CURRENT Organization: The NUXI BSD group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Mar 23, 2002 at 12:03:05PM +1100, Bruce Evans wrote: > On Thu, 21 Mar 2002, David O'Brien wrote: > > > On Fri, Mar 22, 2002 at 04:16:14PM +1100, Bruce Evans wrote: > > > You added new style bugs (missing blank line > > > between vendor id and __FBSDID()), > > > > We disagree on this point, and there is nothing in CSRG history to > > support the blank line. :-P > > Only about 100000 examples of a blank line before the first #include. The CSRG did not have to deal with including a header for their SCM. All SCM IDs should be kept together in the same block of bits. Spreading them out (1) makes them harder to find, (2) pushed the code farther down, so it is harder to read the file. We can always put __FBSDID above the CSRG Ids. This would allow the rule to sited to be followed: /*- * Copyright (c) 1990, 1993 * The Regents of the University of California. All rights reserved. ... * SUCH DAMAGE. */ #include __FBSDID("$FreeBSD"); #if defined(LIBC_SCCS) && !defined(lint) static char sccsid[] = "@(#)printf.c 8.1 (Berkeley) 6/4/93"; #endif /* LIBC_SCCS and not lint */ #include .... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message