Date: Sat, 23 Mar 2002 11:38:14 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/msun/bsdsrc b_exp.c b_log.c b_tgamma.c Message-ID: <20020323113814.C82167@dragon.nuxi.com> In-Reply-To: <20020323120137.T20431-100000@gamplex.bde.org>; from bde@zeta.org.au on Sat, Mar 23, 2002 at 12:03:05PM %2B1100 References: <20020321232232.A21049@dragon.nuxi.com> <20020323120137.T20431-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 23, 2002 at 12:03:05PM +1100, Bruce Evans wrote:
> On Thu, 21 Mar 2002, David O'Brien wrote:
>
> > On Fri, Mar 22, 2002 at 04:16:14PM +1100, Bruce Evans wrote:
> > > You added new style bugs (missing blank line
> > > between vendor id and __FBSDID()),
> >
> > We disagree on this point, and there is nothing in CSRG history to
> > support the blank line. :-P
>
> Only about 100000 examples of a blank line before the first #include.
The CSRG did not have to deal with including a header for their SCM.
All SCM IDs should be kept together in the same block of bits. Spreading
them out (1) makes them harder to find, (2) pushed the code farther down,
so it is harder to read the file.
We can always put __FBSDID above the CSRG Ids. This would allow the rule
to sited to be followed:
/*-
* Copyright (c) 1990, 1993
* The Regents of the University of California. All rights reserved.
...
* SUCH DAMAGE.
*/
#include <sys/cdef.h>
__FBSDID("$FreeBSD");
#if defined(LIBC_SCCS) && !defined(lint)
static char sccsid[] = "@(#)printf.c 8.1 (Berkeley) 6/4/93";
#endif /* LIBC_SCCS and not lint */
#include <stdio.h>
....
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020323113814.C82167>