From nobody Sat May 20 18:38:14 2023 X-Original-To: freebsd-current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QNssw1M4nz4CNWB for ; Sat, 20 May 2023 18:38:28 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QNsst4GhXz3q9k; Sat, 20 May 2023 18:38:26 +0000 (UTC) (envelope-from rick.macklem@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20221208 header.b=RPDXcu7p; spf=pass (mx1.freebsd.org: domain of rick.macklem@gmail.com designates 2607:f8b0:4864:20::52d as permitted sender) smtp.mailfrom=rick.macklem@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pg1-x52d.google.com with SMTP id 41be03b00d2f7-52c40be1417so1397264a12.1; Sat, 20 May 2023 11:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684607905; x=1687199905; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=I+2pau+fOH3uhAgKSRSJA0sAVxbIpLe/aBzbRPMBTqM=; b=RPDXcu7p/IT1HFjNxlJXda/xmwdXP/odAcbwYtqp7/gNISQMpv78dpAQneoM91CnQf FsxFeG2Nn+TZCnTWyVfR7ZBvKPM3uJZ/ZAbY/usEOX2UbXiv7PVetXPDmHPbZy02bkHk DrAI+9oOfdbcPvG6TUifJukBjFPH5hJ7p9/TUTafbCSLegvXU7EMbR5ZYMPdmAQM4jQb 0Y6/EPSAQlegyyuSwbddGRi3GmQ7GB8WFaA4kjF82/3XGWZRLvMWaGAccSiKKVoqlzsm NVGMdlYafiqqefGkGyJ9UcQNkk4lnZYJITRJY/1IymM/m63gmMTvDscC5/gvkj/MJqbL wFPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684607905; x=1687199905; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=I+2pau+fOH3uhAgKSRSJA0sAVxbIpLe/aBzbRPMBTqM=; b=MiUSy8fzLZskhH3e4poYDe7hsnDpCSEwyhbYy5jDNzHICmXjb6TR4heTwbzjgBnj3H YTVF3vfS6rAtImCx/toChzwso8cJ0uYAvuOnL1xpjU8WKzrmQCeMQWQ1Bl7dU1j2d4MN roXc0AAJQmO3gIuU6lQ+dAZPGJFfVcdA29LvB3MzCzMx5Ja2i+OHlQjNyTwTHKC5I3by ABjcTYivJaDfmk8TNwj7iXsLqEgUOWc1PUe5tZ3nrDw59OJc96rQbvXO+bb1q4a4onHd q6Qa2QlYEEQHdcxv1Ck2f8fchGpZLObasMhwVwt1B7Q2Z4ln0fTxIANe7yissKc41DnF qcjQ== X-Gm-Message-State: AC+VfDyN0wntYF+fLJNgDHuoeQMa/GQ3CEmtwj1E3BMzxeUjgXnwfYOT BR6hLDYULkirq5P1kY54NOts3eMz2QC92aIueCRMnygzBQ== X-Google-Smtp-Source: ACHHUZ7OFuc+RBCSbXbDtceaVn8tzuuyPXdQzAZIoyPrV9z2IUlBGY6k3gzFEqWWJ1R7Qyu+lql56/VY+trvueuxE24= X-Received: by 2002:a17:90b:1e05:b0:253:6b3a:ab1e with SMTP id pg5-20020a17090b1e0500b002536b3aab1emr9449890pjb.6.1684607905220; Sat, 20 May 2023 11:38:25 -0700 (PDT) List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@freebsd.org MIME-Version: 1.0 From: Rick Macklem Date: Sat, 20 May 2023 11:38:14 -0700 Message-ID: Subject: RFC: Dealing with an MFC to stable/13 that breaks the lobprocstat build To: FreeBSD CURRENT , James Gritton , Konstantin Belousov , Mark Johnston Content-Type: text/plain; charset="UTF-8" X-Spamd-Result: default: False [-3.39 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-0.39)[-0.389]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20221208]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::52d:from]; RCVD_TLS_LAST(0.00)[]; MLMMJ_DEST(0.00)[freebsd-current@freebsd.org]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; DKIM_TRACE(0.00)[gmail.com:+]; MID_RHS_MATCH_FROMTLD(0.00)[]; TAGGED_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; TO_DN_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Queue-Id: 4QNsst4GhXz3q9k X-Spamd-Bar: --- X-ThisMailContainsUnwantedMimeParts: N Hi, So I did an MFC that broke the stable/13 build (it's reverted now). I didn't realize that changes inside _KERNEL in mount.h would do this, but now I know. Since it is only an issue for stable/13 (and not main), I'd like to do a minimal fix on the MFC and not mess with adding #includes to libprocstat sources. There are two of them: 1 - A prototype for a new function called vfs_exjail_delete(), which is in vfs_export.c and is called in kern_jail.c. --> For this one, I think the easiest fix is to just move the function prototype from mount.h to jail.h. 2 - Adding a "bool" argument to vfs_export(). For this one, I think the easiest fix is to re-define the argument as an "int" and pass it in as 0/1 instead of false/true. Are others agreeable to these changes to the code for the MFS into stable/13? (Not affecting main.) rick