Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 19 Sep 2022 01:59:52 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Neel Chauhan <nc@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: c6b1c1d7ec72 - main - databases/mongodb60: Fix build
Message-ID:  <YyfNGOJCFp0rg5io@FreeBSD.org>
In-Reply-To: <202209182338.28INcRhQ048234@gitrepo.freebsd.org>
References:  <202209182338.28INcRhQ048234@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 18, 2022 at 11:38:27PM +0000, Neel Chauhan wrote:
> commit c6b1c1d7ec72a6591d2b0a87f60a673b0c92bb40
> 
>  databases/mongodb60: Fix build
> 
>  PR:             266394
>  Reported by:    maintainer
> ---
>  databases/mongodb60/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/databases/mongodb60/Makefile b/databases/mongodb60/Makefile
> index dc4d6a459862..2b4323c990b1 100644
> --- a/databases/mongodb60/Makefile
> +++ b/databases/mongodb60/Makefile
> @@ -52,7 +52,7 @@ MAKE_ARGS=	${MAKE_JOBS_NUMBER} \

Actually ${MAKE_JOBS_NUMBER} had been passed on MAKE_ARGS before,
albeit obviously in a wrong way.  Now you "pass" it twice. :)

>  		--use-system-pcre \
>  		--use-system-snappy \
>  		--use-system-zlib \
> -		-j \
> +		-j ${MAKE_JOBS_NUMBER} \

You could probably spell it as ${_MAKE_JOBS} here for simplicity:
using it as part of MAKE_ARGS is canonical so I guess it's okay
despite of the (semi-)private namespace.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YyfNGOJCFp0rg5io>