From owner-cvs-src@FreeBSD.ORG Mon Feb 7 19:15:57 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3861916A4CE; Mon, 7 Feb 2005 19:15:57 +0000 (GMT) Received: from smtp1.server.rpi.edu (smtp1.server.rpi.edu [128.113.2.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 11FA243D1D; Mon, 7 Feb 2005 19:15:56 +0000 (GMT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.netel.rpi.edu [128.113.24.47]) by smtp1.server.rpi.edu (8.13.0/8.13.0) with ESMTP id j17JFj8j014141; Mon, 7 Feb 2005 14:15:51 -0500 Mime-Version: 1.0 Message-Id: In-Reply-To: <20050207081054.GA57554@cirb503493.alcatel.com.au> References: <200502061634.j16GYnuv025551@repoman.freebsd.org> <20050206184516.GB1080@darkness.comp.waw.pl> <20050207081054.GA57554@cirb503493.alcatel.com.au> Date: Mon, 7 Feb 2005 14:15:44 -0500 To: Peter Jeremy , Pawel Jakub Dawidek From: Garance A Drosihn Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-CanItPRO-Stream: default X-RPI-SA-Score: undef - spam-scanning disabled X-Scanned-By: CanIt (www . canit . ca) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ps keyword.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Feb 2005 19:15:57 -0000 At 7:10 PM +1100 2/7/05, Peter Jeremy wrote: >On Sun, 2005-Feb-06, Pawel Jakub Dawidek wrote: > >On Sun, Feb 06, 2005, Christian S.J. Peron wrote: > >+> Since it is not un-common for a process's resident set size (rss) >>+> to exceed 10 megabytes in size (especially in X), bump the max >>+> column width from 4 bytes to 5. This will make the ps auxw output >>+> uniform again when a process's rss exceeds 10 megs. >> >>Maybe we can use humanize_number(3) here? > > Please ensure that if you do use humanize_number(3), there is a > way of getting rss and vsz values in fixed units. My guess is that a 5-byte width will be enough for most users for the short term. I was thinking that if we do use humanize-number for some longer term solution, it would be done via some new explicit option. There are a few other ways to deal with this that I might like to try, too, but I felt this change was a reasonable "quick fix". -- Garance Alistair Drosehn = gad@gilead.netel.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu