From owner-cvs-all@FreeBSD.ORG  Sat Jul 23 19:15:55 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 33C0916A41F;
	Sat, 23 Jul 2005 19:15:55 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from harmony.village.org (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A4C7743D48;
	Sat, 23 Jul 2005 19:15:54 +0000 (GMT) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost.village.org [127.0.0.1])
	by harmony.village.org (8.13.3/8.13.3) with ESMTP id j6NJEb2K021787;
	Sat, 23 Jul 2005 13:14:37 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Sat, 23 Jul 2005 13:15:29 -0600 (MDT)
Message-Id: <20050723.131529.31252138.imp@bsdimp.com>
To: nate@root.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <42E29269.4030305@root.org>
References: <20050723182455.6AD3516A442@hub.freebsd.org>
	<42E29269.4030305@root.org>
X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, ache@freebsd.org,
	cvs-all@freebsd.org
Subject: Re: cvs commit: src/games/fortune/fortune fortune.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 23 Jul 2005 19:15:55 -0000

In message: <42E29269.4030305@root.org>
            Nate Lawson <nate@root.org> writes:
: Andrey A. Chernov wrote:
: > ache        2005-07-23 18:24:47 UTC
: > 
: >   FreeBSD src repository
: > 
: >   Modified files:
: >     games/fortune/fortune fortune.c 
: >   Log:
: >   My change, namely srandomdev() addition, was backed out even without
: >   discussing with me, and I obviously disagree seeing that afterwards
: >   (srandomdev() back out not fix any thing, it can only mask the problem).
: >   
: >   So, back out the back out and return srandomdev().
: >   
: >   People who have problems with repeated quotes should use -D fortune
: >   option for debugging to see is the problem in (1) /dev/random initialization
: >   or in (2) fortune code itself.
: 
: A bug in initializing /dev/random is a security issue and not one to be 
: taken lightly.  I hope whoever is affected by this puts some effort into 
: debugging it.

Agreed.  Andrey did the right thing here.  If we have /dev/random
problems, we need to find, fix and destroy them, not kludge around it
with 1980's microsecond technology.

Warner