From owner-svn-src-all@freebsd.org Mon Nov 12 16:50:31 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6D62110AEC2; Mon, 12 Nov 2018 16:50:31 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1FF4176B2B; Mon, 12 Nov 2018 16:50:31 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 5F5F43C475F; Mon, 12 Nov 2018 16:50:24 +0000 (UTC) Date: Mon, 12 Nov 2018 16:50:24 +0000 From: Brooks Davis To: Eitan Adler Cc: Brooks Davis , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r340294 - head/sys/compat/freebsd32 Message-ID: <20181112165024.GC66623@spindle.one-eyed-alien.net> References: <201811091803.wA9I31ie014903@repo.freebsd.org> <20181109181901.GA61841@spindle.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 1FF4176B2B X-Spamd-Result: default: False [-0.98 / 200.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.95)[-0.950,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-0.95)[-0.950,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MX_GOOD(-0.01)[spindle.one-eyed-alien.net]; MX_MISSING(3.50)[requested record is not found]; NEURAL_HAM_SHORT(-0.88)[-0.876,0]; R_SPF_NA(0.00)[]; SIGNED_PGP(-2.00)[]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; R_DKIM_NA(0.00)[]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; IP_SCORE(-0.80)[asn: 36236(-3.88), country: US(-0.09)]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Nov 2018 16:50:32 -0000 --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 10, 2018 at 12:18:13AM -0800, Eitan Adler wrote: > On Fri, 9 Nov 2018 at 10:19, Brooks Davis wrote: > > > > On Fri, Nov 09, 2018 at 06:03:01PM +0000, Brooks Davis wrote: > > > Author: brooks > > > Date: Fri Nov 9 18:03:01 2018 > > > New Revision: 340294 > > > URL: https://svnweb.freebsd.org/changeset/base/340294 > > > > > > Log: > > > Fix a number of bugs in freebsd32's capabilities.conf. > > > > > > Bugs range from failure to update after changing syscall implementa= ion > > > names to using the wrong name. Somewhat confusingly, the name in > > > capabilities.conf is exactly the string that appears in syscalls.ma= ster, > > > not the name with a COMPAT* prefix which is the actual function nam= e. > > > > > > Found while making a change to use the default capabilities.conf. >=20 > Is there any automated way to detect this in the future? Can we add > some test that detect non-existent syscalls or the like? https://reviews.freebsd.org/D17932 fixes most of this. It wouldn't be too hard to keep track of which syscalls were emitted and check that against the set from capabilities.conf. I'll keep that in mind. -- Brooks --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJb6a9PAAoJEKzQXbSebgfAW4cIAJT9Kx4h33Ot0XFw/oCduNsX AM2zwRmX5cbejqzr8A4hGN5khczXPzJRqFIg8IJAa8pQ1ZIpVSsfwX5F/EYsW0Fz gJUe+wNqm51dPqUZTCyXpUFApqTiPAHjZYU3c2DwhUJu/wfnsI9dqO1r0I3ZCxMK GM7fTVTpU5cNrk2OdZdOsFxe4Bpu2tfgq/PfMwedlQQovu/2X9KGV+JPC/YNRhKt oq8qenKXx0y5aT0tM/mgnPRjbMyyHAkY3dshvq+AcKCMMVvHkVePjldA1lEX8r+W 0CpkearE65JMzEpjHnTKFlN3UqQ97Gu0gWc7IR3lAvVqW05EsAoJLXm9rF2tRz4= =5ZxW -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--