From owner-freebsd-x11@FreeBSD.ORG  Sun Apr 15 02:13:23 2007
Return-Path: <owner-freebsd-x11@FreeBSD.ORG>
X-Original-To: x11@freebsd.org
Delivered-To: freebsd-x11@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id AC35F16A400
	for <x11@freebsd.org>; Sun, 15 Apr 2007 02:13:23 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 97CEC13C469
	for <x11@freebsd.org>; Sun, 15 Apr 2007 02:13:23 +0000 (UTC)
	(envelope-from kris@obsecurity.org)
Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196])
	by elvis.mu.org (Postfix) with ESMTP id BDBC11A3C1C;
	Sat, 14 Apr 2007 19:13:34 -0700 (PDT)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id A2B0251396; Sat, 14 Apr 2007 22:13:22 -0400 (EDT)
Date: Sat, 14 Apr 2007 22:13:22 -0400
From: Kris Kennaway <kris@obsecurity.org>
To: Dejan Lesjak <dejan.lesjak@ijs.si>
Message-ID: <20070415021322.GB77534@xor.obsecurity.org>
References: <20070414194028.GB2313@xor.obsecurity.org>
	<200704142311.47387.dejan.lesjak@ijs.si>
	<20070415013921.GA68262@xor.obsecurity.org>
	<200704150410.46839.dejan.lesjak@ijs.si>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="f2QGlHpHGjS2mn6Y"
Content-Disposition: inline
In-Reply-To: <200704150410.46839.dejan.lesjak@ijs.si>
User-Agent: Mutt/1.4.2.2i
Cc: x11@freebsd.org, Kris Kennaway <kris@obsecurity.org>
Subject: Re: Upgrade script
X-BeenThere: freebsd-x11@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: X11 on FreeBSD -- maintaining and support <freebsd-x11.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
	<mailto:freebsd-x11-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-x11>
List-Post: <mailto:freebsd-x11@freebsd.org>
List-Help: <mailto:freebsd-x11-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-x11>,
	<mailto:freebsd-x11-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Apr 2007 02:13:23 -0000


--f2QGlHpHGjS2mn6Y
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Apr 15, 2007 at 04:10:46AM +0200, Dejan Lesjak wrote:
> On Sunday 15 April 2007 03:39:22 Kris Kennaway wrote:
> > One more thing I spotted is that it doesn't handle
> > non-default X11BASE or LOCALBASE.  Probably the way to do this is to
> > use
> >
> > PORTSDIR?=3D/usr/ports
> > X11BASE=3D`make -f ${PORTSDIR}/Mk/bsd.port.mk -V X11BASE`
> >
> > or similar.  Using bsd.port.mk is so it picks up the default value,
> > and includes /etc/make.conf to check for override.  It also DTRT if
> > X11BASE is set in the environment.
>=20
> Hmm. I wouldn't use too much automagic in that case. I'm not sure it's go=
od to=20
> assume that if someone has changed the defaults that this script will do =
the=20
> right thing for them regardless if it properly detects changed=20
> X11BASE/LOCALBASE. I'd rather say they can change variables at beginning =
of=20
> the script. Perhaps printing the message saying that this should be chang=
ed=20
> if using non-default (and also to change BACKUPDIR) and then ask for=20
> confirmation to continue?

Yes, that is probably best.

Kris


--f2QGlHpHGjS2mn6Y
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (FreeBSD)

iD8DBQFGIYpCWry0BWjoQKURAlTBAJ0YcyLj2jKfDPNEaKDVDedj90QWKwCcCU+V
UjSTRitK3JrTetgFlGlJyx8=
=1kw+
-----END PGP SIGNATURE-----

--f2QGlHpHGjS2mn6Y--