From owner-svn-src-all@freebsd.org Sun Apr 19 20:57:27 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7FF242A9E53; Sun, 19 Apr 2020 20:57:27 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4952Fz2fHJz3yh8; Sun, 19 Apr 2020 20:57:27 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x541.google.com with SMTP id r4so4020874pgg.4; Sun, 19 Apr 2020 13:57:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rbbZDMBVCnK/Z+JqgfjH+cKdy63mlPu0dKxtwyaDdR4=; b=WsFnROHgxvD6G3RvBfNToJQyzR3hK4Hq4mCQZ5tTzNDKMkL4VXe+UrEnfpRUk+yr5+ 3fe6EXG5VLLZzU7XpuhLSHREjmcKo0XHxd6QLxJGqTdBrO6N3sXWlqZHbI3ZJD41d4Ai WiVnXp62gTaIO9ucrXGlAa0gIsuMSvM8G8W3Q1cCzfTK1DjSQZb1kmu4XRVq3tIzTkoZ J0EmS8rSkFljkzr2V7Om32fLlpAp5nm3Qit5hpVkVkaYgASL8exhN7W/7pNzuzuaeWA5 gr5lq7+xYYeEpvrOj6ZRnRs0W+/FIhj1npnnQgIXzA9XqmCmkXi61HFaeAMwsfjsuQwE B5xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=rbbZDMBVCnK/Z+JqgfjH+cKdy63mlPu0dKxtwyaDdR4=; b=kMoaNKdrEcbN5rwZgxKLe8X+QlURRGEU+FYpvGWMEo+FcPf5gAz2V2qhXSNK7YlcMZ NYEaW/7dVvc6xLQSi632GyoR1mSI+1d0qfsFebrhfDFTfzDb556ijwxbA96FZvwUJhsc mqs4mvZPEx+/wipvGx8sMtMews14tWzTHQyWmQ6FolYi3EGy/OCqTFpVwNqSHT0Jb946 LkKzfUtcfJ12hO8QWgonokhGqGdOHAbxSvftHZje2dm+1gKiWDSqxA93+7WEB+uKiHlG joIUh/3P6FhjoOhFm3sE5UoxoQ0/3VbbFVdAd3pbuvnaj4T5pelIOsIVI0M8D/pRQAPg J1ZA== X-Gm-Message-State: AGi0PuYu7YrtleRSjw+8kH+pX65pXU9GEU5rnQxeJUIdouz/LyB224py uEnI6JDEe/JYqSpcj8WcuJjiv7jQz8A= X-Google-Smtp-Source: APiQypKYP3g1t6knxdcr7s1C9w+ntaRIO0UmKxassEDRyhr5NshtEnIFEUKted2YM9NLgUQOjIa64Q== X-Received: by 2002:a63:b557:: with SMTP id u23mr13297392pgo.160.1587329845128; Sun, 19 Apr 2020 13:57:25 -0700 (PDT) Received: from [192.168.20.26] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id c24sm5925459pfi.170.2020.04.19.13.57.23 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Apr 2020 13:57:24 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: svn commit: r360102 - in head: libexec/rc/rc.d share/mk tools/build/mk From: Enji Cooper In-Reply-To: <202004191701.03JH1LFA002938@repo.freebsd.org> Date: Sun, 19 Apr 2020 13:57:23 -0700 Cc: src-committers , svn-src-all , svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <202004191701.03JH1LFA002938@repo.freebsd.org> To: Cy Schubert X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Rspamd-Queue-Id: 4952Fz2fHJz3yh8 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Apr 2020 20:57:27 -0000 > On Apr 19, 2020, at 10:01 AM, Cy Schubert wrote: >=20 > Author: cy > Date: Sun Apr 19 17:01:21 2020 > New Revision: 360102 > URL: https://svnweb.freebsd.org/changeset/base/360102 >=20 > Log: > Conditionally install Kerberos rc files based on MK_KERBEROS_SCRIPTS > instead of MK_KERBEROS. The reason for this change is some users > prefer to build FreeBSD WITHOUT_KERBEROS, wanting to retain the > Kerberos rc scripts to start/stop MIT Kerberos or Heimdal from ports. >=20 > PR: 197337 > Reported by: Adam McDougall > Reviewed by: imp > Differential Revision: https://reviews.freebsd.org/D24252 Hi Cy, Having excised code like this in the past, I don=E2=80=99t think = this is the right approach: a separate slave port should be added that = handles the rc.d script installation, etc, or the scripts should be = added to the manifest for the ports. Thanks, -Enji=