Date: Sun, 20 Mar 2005 12:32:21 -0500 From: Adam Weinberger <adamw@FreeBSD.org> To: Hye-Shik Chang <perky@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/liferea Makefile distinfo pkg-plist Message-ID: <423DB3A5.8070207@FreeBSD.org> In-Reply-To: <200503201704.j2KH4EAY028655@repoman.freebsd.org> References: <200503201704.j2KH4EAY028655@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hye-Shik Chang wrote:
> perky 2005-03-20 17:04:14 UTC
>
> FreeBSD ports repository
>
> Modified files:
> net/liferea Makefile distinfo pkg-plist
> Log:
> Update to 0.9.1.
Can this port please please be updated to respect WITH_MOZILLA? This
port should work just fine if someone is using a firefox backend, but as
it stands now, it forces people to have mozilla installed.
Furthermore, you should not be using WITH_MOZILLA as a check variable
without honouring its contents. Anybody who has mozilla-devel installed,
or chooses to have firefox as their only mozilla-based backend, will
have WITH_MOZILLA set in their environment. That means that there's no
way to disable mozilla support for these people in liferea.
Please look at galeon or epiphany or mplayer-plugin etc. to see what
other ports do with the WITH_MOZILLA variable.
I think you should do the following:
.if WITH_MOZILLA=="firefox" || WITH_MOZILLA="mozilla" || \
WITH_MOZILLA="mozilla-devel"
BUILD_DEPENDS= ${WITH_MOZILLA}:${PORTSDIR}/www/${WITH_MOZILLA}
.else
.if defined(WITH_MOZILLA)
BUILD_DEPENDS= mozilla:${PORTSDIR}/www/mozilla
.fi
.fi
RUN_DEPENDS= ${BUILD_DEPENDS}
This way, if a user has WITH_MOZILLA set to the browser of their choice,
that browser will be registered as a dependency (and liferea will stop
corrupting everyone's package database every single time it's installed
or upgraded). Users can still set WITH_MOZILLA to "yes" or whatever to
force a dependency on mozilla, similar to what the port expects right now.
# Adam
--
Adam Weinberger
adamw@magnesium.net || adamw@FreeBSD.org
adamw@vectors.cx || adamw@gnome.org
http://www.vectors.cx
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?423DB3A5.8070207>