From owner-freebsd-current@FreeBSD.ORG Tue Jun 10 11:16:47 2008 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C6A2210657C4 for ; Tue, 10 Jun 2008 11:16:47 +0000 (UTC) (envelope-from flo@kasimir.com) Received: from kasimir.com (kasimir.com [85.214.51.166]) by mx1.freebsd.org (Postfix) with ESMTP id 3A0128FC2B for ; Tue, 10 Jun 2008 11:16:47 +0000 (UTC) (envelope-from flo@kasimir.com) Received: (qmail 29037 invoked from network); 10 Jun 2008 13:16:45 +0200 Received: from relay3.vistream.de (HELO nibbler.vistream.local) (87.139.10.28) by kasimir.com with SMTP; 10 Jun 2008 13:16:45 +0200 Message-ID: <484E627C.6090909@kasimir.com> Date: Tue, 10 Jun 2008 13:16:12 +0200 From: Florian Smeets User-Agent: Thunderbird 2.0.0.15pre (Macintosh/20080603) MIME-Version: 1.0 To: John Baldwin References: <200805302339.33935.jhb@freebsd.org> <200806031041.08315.jhb@freebsd.org> <4845B8F7.7060600@kasimir.com> <200806041100.20911.jhb@freebsd.org> In-Reply-To: <200806041100.20911.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: current@freebsd.org Subject: Re: tx(4) MPSAFE patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jun 2008 11:16:47 -0000 John Baldwin wrote: > On Tuesday 03 June 2008 05:34:47 pm Florian Smeets wrote: >> John Baldwin wrote: >>> On Monday 02 June 2008 07:10:11 pm Florian Smeets wrote: >>>> Florian Smeets wrote: >>>>> John Baldwin wrote: >>>>>> On Monday 02 June 2008 05:09:57 pm Florian Smeets wrote: >>>>>>> John Baldwin wrote: >>>>>>>> I have a patch to make tx(4) MPSAFE. I do not have the hardware to >>>>>>>> test >>>>>> this >>>>>>>> however. Unlike many of the previous patches, though, this driver >>>>>>>> appears >>>>>> to >>>>>>>> be for hardware that is not entirely ancient, so there is hopefully a >>>>>> decent >>>>>>>> chance someone can test this. >>>>>>>> >>>>>>>> http://www.FreeBSD.org/~jhb/patches/tx.patch >>>>>>>> >>> Ok, I've updated the patch again (same URL) which should fix the witness >>> warnings. I also botched the watchdog timer in the previous patch and > that >>> should be fixed now, too. >>> >> Hi John, >> >> still no go. Another mutex not owned panic. I'll be away until Tuesday, >> I'll be happy to test further patches than. > > Ok, I've updated the patch again as that assertion isn't needed (there isn't a > need for locking during prior to ether_ifattach() and bus_setup_intr()). > Hi John, it works as expected now tx0: port 0xc400-0xc4ff mem 0xe7000000-0xe7000fff irq 18 at device 11.0 on pci0 miibus0: on tx0 acphy0: PHY 3 on miibus0 acphy0: 10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto type SMC9432TX_2 tx0: Ethernet address: 00:e0:29:6c:2e:47 tx0: [ITHREAD] I tried to push some traffic through the interface and no strange symptoms yet. So i guess the patch is O.K. now. Cheers, Florian