Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Jun 2008 13:16:12 +0200
From:      Florian Smeets <flo@kasimir.com>
To:        John Baldwin <jhb@freebsd.org>
Cc:        current@freebsd.org
Subject:   Re: tx(4) MPSAFE patch
Message-ID:  <484E627C.6090909@kasimir.com>
In-Reply-To: <200806041100.20911.jhb@freebsd.org>
References:  <200805302339.33935.jhb@freebsd.org> <200806031041.08315.jhb@freebsd.org> <4845B8F7.7060600@kasimir.com> <200806041100.20911.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
John Baldwin wrote:
> On Tuesday 03 June 2008 05:34:47 pm Florian Smeets wrote:
>> John Baldwin wrote:
>>> On Monday 02 June 2008 07:10:11 pm Florian Smeets wrote:
>>>> Florian Smeets wrote:
>>>>> John Baldwin wrote:
>>>>>> On Monday 02 June 2008 05:09:57 pm Florian Smeets wrote:
>>>>>>> John Baldwin wrote:
>>>>>>>> I have a patch to make tx(4) MPSAFE.  I do not have the hardware to 
>>>>>>>> test 
>>>>>> this
>>>>>>>> however.  Unlike many of the previous patches, though, this driver 
>>>>>>>> appears 
>>>>>> to
>>>>>>>> be for hardware that is not entirely ancient, so there is hopefully a 
>>>>>> decent
>>>>>>>> chance someone can test this.
>>>>>>>>
>>>>>>>> http://www.FreeBSD.org/~jhb/patches/tx.patch
>>>>>>>>
>>> Ok, I've updated the patch again (same URL) which should fix the witness 
>>> warnings.  I also botched the watchdog timer in the previous patch and 
> that 
>>> should be fixed now, too.
>>>
>> Hi John,
>>
>> still no go. Another mutex not owned panic. I'll be away until Tuesday, 
>> I'll be happy to test further patches than.
> 
> Ok, I've updated the patch again as that assertion isn't needed (there isn't a 
> need for locking during prior to ether_ifattach() and bus_setup_intr()).
> 

Hi John,

it works as expected now

tx0: <SMC EtherPower II 10/100> port 0xc400-0xc4ff mem 
0xe7000000-0xe7000fff irq 18 at device 11.0 on pci0
miibus0: <MII bus> on tx0
acphy0: <AC101 10/100 media interface> PHY 3 on miibus0
acphy0:  10baseT, 10baseT-FDX, 100baseTX, 100baseTX-FDX, auto
  type SMC9432TX_2
tx0: Ethernet address: 00:e0:29:6c:2e:47
tx0: [ITHREAD]

I tried to push some traffic through the interface and no strange 
symptoms yet. So i guess the patch is O.K. now.

Cheers,
Florian



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?484E627C.6090909>