Date: Sat, 13 Jan 2018 15:06:12 -0500 From: Pedro Giffuni <pfg@FreeBSD.org> To: cem@freebsd.org Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327940 - head/sys/contrib/zstd/lib/freebsd Message-ID: <8b3461ef-0d7d-fc61-5f27-0639301683dd@FreeBSD.org> In-Reply-To: <CAG6CVpWbXGUC%2Bk3mm=zyEgJNvUBQV0XsK99WZyaGQZ2PPtdGXw@mail.gmail.com> References: <201801131902.w0DJ2p5m097642@repo.freebsd.org> <CAG6CVpXN1=yDvbmjV9u-hn1_jNkq937zuDTp=WXy9CM4A9P3aw@mail.gmail.com> <db2419fe-8222-37fa-8ef6-d49616439d5e@FreeBSD.org> <CAG6CVpWbXGUC%2Bk3mm=zyEgJNvUBQV0XsK99WZyaGQZ2PPtdGXw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13/01/2018 14:59, Conrad Meyer wrote: > On Sat, Jan 13, 2018 at 11:54 AM, Pedro Giffuni <pfg@freebsd.org> wrote: >> On 01/13/18 14:24, Conrad Meyer wrote: >> >> This is not in contrib code -- >> https://lists.freebsd.org/pipermail/svn-src-all/2018-January/156505.html >> . >> Thanks, I read it late... >> >> Shouldn't the local code be in usr.bin/zstd ? > No — this code ports zstd to the kernel. It would not make sense in usr.bin. Bah, yes, it should be somewhere else under sys but then if you use it for ZFS and somewhere else, it's not clear where it should go .. nevermind. I was just backtracing. Please add yourself to the MAINTAINERS file if you want pre-commit reviews. Pedro.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8b3461ef-0d7d-fc61-5f27-0639301683dd>