From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Nov 16 02:10:17 2014 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4F27CDF6 for ; Sun, 16 Nov 2014 02:10:17 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 36133610 for ; Sun, 16 Nov 2014 02:10:17 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id sAG2AHdW020549 for ; Sun, 16 Nov 2014 02:10:17 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 195014] [NEW PORT] games/diaspora: Single and multiplayer space fighter combat game Date: Sun, 16 Nov 2014 02:10:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Nov 2014 02:10:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195014 lightside changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149457|0 |1 is obsolete| | --- Comment #19 from lightside --- Created attachment 149465 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=149465&action=edit The port in shar format (In reply to John Marino from comment #18) > If the distfile changes and the maintainer *doesn't* check the plist, it > will pass even if the empty directories change. So nothing forces the > maintainer to actually check -- only if a new file gets install would a > problem be detected by qa checks. Actually, I tested the port (poudriere testport) without using empty directories package list generation at first and I got stage-qa issue about stage directories not in a package list. These directories might be important for users, if they wanted to add files to them (either by root privileges or copy/link the share/diaspora directory to a different location). Therefore, I added dynamic generation for empty directories to ${TMPPLIST}. After this, the stage-qa was ok: ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) ====>> Checking for staging violations... done After discussion, I changed the generation of empty directory list to the following command: cd ${STAGEDIR}${DATADIR} && ${FIND} data -type d -empty | ${SORT} |\ ${XARGS} -L 1 -I '{}' ${ECHO_CMD} "@dir ${DATADIR}/{}"\ >> ${TMPPLIST} The ${STAGEDIR}${DATADIR} is more appropriate place. In the next message I will attach the ${WRKDIR} directory archive of the files after "make check-plist" command. It contains .* hidden files, which you could examine about correctness, especially .PLIST.mktmp, .plist-dirs-sorted-no-comments, .plist-files-no-comments. (In reply to John Marino from comment #18) > I acknowledge this is a very low-risk port in any case. I'll promote the PR > to the next level with a static plist. If you insist on a dynamic plist > then I'll let someone else promote it. I understood. I just think that my method is also correct. Moreover, I have documented results of it written to logs, which is about 3 hours of computer time (because of package generation) for three FreeBSD versions, not counting undocumented computer time for correct result, even on one FreeBSD version. The easy way to check this is just install the port, then find empty "/usr/local/share/diaspora/data" directories, next deinstall the port and find that there is no "/usr/local/share/diaspora" directory, e.g.: # portmaster -Bd games/diaspora # find /usr/local/share/diaspora/data -type d -empty | sort # pkg delete -x diaspora # ls /usr/local/share/diaspora What I could offer is another poudriere testport log of current changes for FreeBSD 10 amd64 version. -- You are receiving this mail because: You are the assignee for the bug.