From owner-freebsd-rc@FreeBSD.ORG Fri Jan 20 23:43:02 2012 Return-Path: Delivered-To: freebsd-rc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4AD8E106564A; Fri, 20 Jan 2012 23:43:02 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) by mx1.freebsd.org (Postfix) with ESMTP id 9D9148FC0A; Fri, 20 Jan 2012 23:43:00 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.4/8.14.4) with ESMTP id q0KN306u089274; Fri, 20 Jan 2012 17:03:00 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.4/8.14.4/Submit) id q0KN30oj089273; Fri, 20 Jan 2012 17:03:00 -0600 (CST) (envelope-from brooks) Date: Fri, 20 Jan 2012 17:03:00 -0600 From: Brooks Davis To: Dirk Engling Message-ID: <20120120230300.GE87357@lor.one-eyed-alien.net> References: <4F14F4FF.902@erdgeist.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wTWi5aaYRw9ix9vO" Content-Disposition: inline In-Reply-To: <4F14F4FF.902@erdgeist.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-rc@freebsd.org Subject: Re: Bumping a pet bug X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2012 23:43:02 -0000 --wTWi5aaYRw9ix9vO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 17, 2012 at 05:11:43AM +0100, Dirk Engling wrote: > Dear rc team, >=20 > I know your time is precious, but there is an annoying bug in rc.d/jail > that keeps littering my (and my user's) servers with stray soft links > whenever we start jails. >=20 > I've described the bug two years ago here >=20 > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3Dconf/143084 >=20 > and even conveniently applied a simple and effective patch. >=20 > tl;dr: If rc.d/jail can not access $_devdir, a soft link is created in > ./log =3D> ../var/run/log no matter where I was. >=20 > Unfortunally I am still busy answering emails from users of ezjail who > first look for the problem with themselves, then blame it on ezjail and > finally complain about FreeBSD. Also I have to clean up my systems from > all the littering links called "log" pointing nowhere. >=20 > If please a committer could take the five minutes to look into the bug > and fix the problem, he could save me and my users a lot of trouble and > time. I've committed a similar fixed to head after talking it over a bit with Simon. We probably would be checking for success on mounting devfs and failed the jail entirely if it doesn't happen, but that's a bigger step and from your description it appears to me that might cause problems in some scenarios. -- Brooks P.S. rc.d/jail fixes are the sort of thing that will often need active followup when assigned to freebsd-rc. There's a note at the top that most of us take to mean "don't touch this file without so approval" which is a moderate psychological barrier to handling these PRs. --wTWi5aaYRw9ix9vO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFPGfKjXY6L6fI4GtQRAkFwAJ9qp0TbImNQQdk0UqugD0Y5WojcWACfXRia 3S5UvLjsToJXndvoB5+hKcY= =X2Xb -----END PGP SIGNATURE----- --wTWi5aaYRw9ix9vO--