From owner-freebsd-hardware@FreeBSD.ORG Mon Jan 14 20:50:29 2013 Return-Path: Delivered-To: freebsd-hardware@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D168558D for ; Mon, 14 Jan 2013 20:50:29 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id A8F56995 for ; Mon, 14 Jan 2013 20:50:29 +0000 (UTC) Received: from pakbsde14.localnet (unknown [38.105.238.108]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id D743FB963; Mon, 14 Jan 2013 15:50:28 -0500 (EST) From: John Baldwin To: freebsd-hardware@freebsd.org Subject: Re: ppc fails to attach to puc on 9.1-STABLE, 7.4-STABLE works Date: Mon, 14 Jan 2013 15:02:58 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p22; KDE/4.5.5; amd64; ; ) References: <20130110074052.GA8922@bali> In-Reply-To: <20130110074052.GA8922@bali> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201301141502.58550.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Mon, 14 Jan 2013 15:50:28 -0500 (EST) X-BeenThere: freebsd-hardware@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: General discussion of FreeBSD hardware List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Jan 2013 20:50:29 -0000 On Thursday, January 10, 2013 2:40:52 am Andre Albsmeier wrote: > [Retrying here, maybe anyone can help...} > > I want my printer port back on 9.1 ;-( > > I have this card: > > puc0@pci0:4:1:0: class=0x078000 card=0x00121000 chip=0x98359710 rev=0x01 hdr=0x00 > vendor = 'NetMos Technology' > device = 'PCI 9835 Multi-I/O Controller' > class = simple comms > > It attached and worked under 7.4-STABLE (as long as I disabled > the interrupt using hint.ppc.0.irq=""): > > puc0: port 0xdf00-0xdf07,0xde00-0xde07,0xdd00-0xdd07 > ,0xdc00-0xdc07,0xdb00-0xdb07,0xda00-0xda0f irq 17 at device 1.0 on pci4 > puc0: [FILTER] > uart0: on puc0 > uart0: [FILTER] > uart1: on puc0 > uart1: [FILTER] > ppc0: on puc0 > ppc0: Generic chipset (ECP/EPP/PS2/NIBBLE) in ECP+EPP mode (EPP 1.9) > ppbus0: on ppc0 > lpt0: on ppbus0 > lpt0: Polled port > > > Under 9.1 the card does not attach the ppc anymore. The hint entries > > hint.ppc.0.at=puc0 > hint.ppc.0.irq="" > hint.ppc.0.flags=0x2F > > get ignored and so it probes as ppc1 (failing due to the interrupt > problem as it was in 7.4 without hints): > > puc0: port 0xdf00-0xdf07,0xde00-0xde07,0xdd00-0xdd07 > ,0xdc00-0xdc07,0xdb00-0xdb07,0xda00-0xda0f irq 17 at device 1.0 on pci4 > uart2: at port 1 on puc0 > uart3: <16550 or compatible> at port 2 on puc0 > ppc1: at port 3 on puc0 > ppc1: Generic chipset (EPP/NIBBLE) in COMPATIBLE mode > ppc1: failed to register interrupt handler: 6 > device_attach: ppc1 attach returned 6 > > Any ideas? How do I construct the hint entries under 9.1 so that > > 1. it does not want to use the interrupt (which made it attach under 7.4) > 2. it takes the flags 0x2F as it did before. > > I have also never understood if ppc itself needs to attach to > the irq as well (I thought this all would be handled by puc). Well, ppc wants to use puc's interrupt, and it should be finding puc's interrupt. Ah, I think I found the bug. Try this patch to sys/dev/puc/puc.c: Index: puc.c =================================================================== --- puc.c (revision 245225) +++ puc.c (working copy) @@ -622,7 +628,7 @@ puc_bus_setup_intr(device_t dev, device_t child, s if (cookiep == NULL || res != port->p_ires) return (EINVAL); /* We demand that serdev devices use filter_only interrupts. */ - if (ihand != NULL) + if (port->p_type == PUC_TYPE_SERIAL && ihand != NULL) return (ENXIO); if (rman_get_device(port->p_ires) != originator) return (ENXIO); This should let your ppc device re-use IRQ 17 from your puc device. -- John Baldwin