From owner-cvs-src-old@FreeBSD.ORG Tue Apr 28 19:20:23 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 90B5F1065675 for ; Tue, 28 Apr 2009 19:20:23 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 63B718FC18 for ; Tue, 28 Apr 2009 19:20:23 +0000 (UTC) (envelope-from cognet@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n3SJKNL4028452 for ; Tue, 28 Apr 2009 19:20:23 GMT (envelope-from cognet@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n3SJKNK2028451 for cvs-src-old@freebsd.org; Tue, 28 Apr 2009 19:20:23 GMT (envelope-from cognet@repoman.freebsd.org) Message-Id: <200904281920.n3SJKNK2028451@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to cognet@repoman.freebsd.org using -f From: Olivier Houchard Date: Tue, 28 Apr 2009 19:20:13 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/lib/libc/arm/string strncmp.S X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Apr 2009 19:20:23 -0000 cognet 2009-04-28 19:20:13 UTC FreeBSD src repository Modified files: lib/libc/arm/string strncmp.S Log: SVN rev 191633 on 2009-04-28 19:20:13Z by cognet Change the test at the beginning of strncmp(), from being if (len - 1) < 0 to if (len == 0). The length is supposed to be unsigned, so len - 1 < 0 won't happen except if len == 0 anyway, and it would return 0 when it shouldn't, if len was > INT_MAX. Spotted out by: Channa Revision Changes Path 1.3 +4 -4 src/lib/libc/arm/string/strncmp.S