Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Jul 2009 15:22:09 +1000
From:      John Marshall <john.marshall@riverwillow.com.au>
To:        Eygene Ryabinkin <rea-fbsd@codelabs.ru>
Cc:        Marcel Moolenaar <xcllnt@mac.com>, freebsd-current@freebsd.org
Subject:   Re: 8.0-BETA1 bsdlabel broken?
Message-ID:  <20090713052209.GC982@rwpc12.mby.riverwillow.net.au>
In-Reply-To: <OLkQkjh4JtvZ8Q7GFHMAD2ALVfs@UL%2BEw68dotyeVWwcX17wEARTb1s>
References:  <20090710071023.GB32316@rwpc12.mby.riverwillow.net.au> <20090710112631.GE32316@rwpc12.mby.riverwillow.net.au> <3a142e750907100433y307f9b2bya1dc54953bdf5de2@mail.gmail.com> <0B1F6799-2FAC-4C01-A978-42E247979CAB@mac.com> <1z5niluEh3OBPNSdMbOMyoEwzX4@CWODRlDR5RMqbkBfR0/UzHcfNhE> <267A655F-13A6-4D79-A933-3A78854AC5FD@mac.com> <TiR5kGIN59NiPk3Q5HjMiImYooQ@MbxgtlHN37ICHkxRO9kSrKasfoA> <A70794BC-F018-4F0A-9AF9-56E28D2B4845@mac.com> <LfBOtJAxBxAex2vUkLqeg/IZi/0@UL%2BEw68dotyeVWwcX17wEARTb1s> <OLkQkjh4JtvZ8Q7GFHMAD2ALVfs@UL%2BEw68dotyeVWwcX17wEARTb1s>

next in thread | previous in thread | raw e-mail | index | archive | help

--9jxsPFA5p3P2qPhR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, 12 Jul 2009, 03:12 +0400, Eygene Ryabinkin wrote:
> OK, changed the patch to make the described checks.  And to fix the error
> with the previous patch -- it will set the offset for writes to zero, so
> it is better to use this patch variant for doing label writes and never
> use the previous one for label modifications.  Though it was doing the
> proper thing for reads.

Thank you!  I applied this patch to bsdlabel.c and now the utility
interprets the labels as expected.

rwsrv05# disklabel /dev/da0s1
# /dev/da0s1:
8 partitions:
#        size   offset    fstype   [fsize bsize bps/cpg]
  a:  1048576        0    4.2BSD     2048 16384     8=20
  b:  8388608  1048576      swap                   =20
  c: 33543720        0    unused        0     0         # "raw" part, don't=
 edit
  e:  4194304  9437184    4.2BSD     2048 16384 28552=20
  f: 19912232 13631488    4.2BSD     2048 16384 28552=20

rwsrv05# disklabel /dev/da0s2
# /dev/da0s2:
8 partitions:
#        size   offset    fstype   [fsize bsize bps/cpg]
  c: 67103505        0    unused        0     0         # "raw" part, don't=
 edit
  d: 33554432        0    4.2BSD     2048 16384 28552=20
  e: 33549073 33554432    4.2BSD     2048 16384 28552=20

> But anyway, bsdlabel won't let you write the label (old, patched with
> bad patch, patched with the current patch), since it wants to do it via
> the BSD class and our slicer is PART.  Another patch will be submitted ;))

--=20
John Marshall

--9jxsPFA5p3P2qPhR
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.11 (FreeBSD)

iEYEARECAAYFAkpaxIEACgkQw/tAaKKahKJh+ACdHXEHMKrUPW52Y3qYV6zgajJk
vokAoIyhupl6HtJv8BdJGA8gBC3owuMF
=sFCG
-----END PGP SIGNATURE-----

--9jxsPFA5p3P2qPhR--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090713052209.GC982>