From owner-svn-src-all@freebsd.org Mon Jan 21 04:13:03 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E05A4148E66A; Mon, 21 Jan 2019 04:13:02 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-it1-x12c.google.com (mail-it1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 64E326CEF2; Mon, 21 Jan 2019 04:13:02 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-it1-x12c.google.com with SMTP id p197so13486429itp.0; Sun, 20 Jan 2019 20:13:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Dj7BYeyNUbLn+KU27VKJYtSNyFPXbQummQIJ5bA5pgs=; b=czdCTcChMbzfH0hQdoeRUfTKifkfSccBfUYkkOLQ5w0uecg2/xkwQJsn5sMtQuGolZ hs2mE1Vt9Z2ToqxfxgIcFMZqvI4RMfTNn3/ATKoq4yToABj87BtGaV1XKYPwLsQvkH17 Wti0KWphyJ/ZqkuTuh4pCCfRNfYo2E0i0JscZLZZ5Wt+cyNDCiz765SYeeSBPx6sI838 x2h0Xa2VGJPVcfZcU43RKw8aTlmaDSqw3/mk0R1ELkCKGCSmbZcD4pZKlSvarcYwSFXm Q25R5Z7nJINJqhg+1oWYi1H/1w4ORA2VthjHK4Wv9ko10VEu917hFA4WE/DrPpMrwr9+ 34ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=Dj7BYeyNUbLn+KU27VKJYtSNyFPXbQummQIJ5bA5pgs=; b=qVCUMxKslT/nyrGa5puYaJUTyfrcoeOfEWsyVkS9QnCrVByVDU3Et8X23P2wiKl+6M 5B8AWDOshy/iPp7XC9YKqi9IG1MMyPMJ48iKZpYN2grigPqCfKqzqLH+BaM2iGqossuD OylEEKIlWatqVABC6JagKNyt6bliXK1poAFCbofYIdvqBbKXYca79sLCG7evivo0lXmj Qo41BoYypdbxlhvaq09N+xOEq6I+qihYAoI8NECpCYEfctvx+rg0WUtZxa1R7hGAqWYw FfDEggFAuU6kxS1SGRi6p1YP7cVG2HkOk41OmxCIdWe7Ey2+RfVWVKiLe135pYKpIj30 QAHg== X-Gm-Message-State: AJcUukdK+2vwvZXNVkAelB7s6a0T39sdLUkqOWhFMRvAxKWjTEOf+Pj8 PKaKwNuXb8oRWgidjMMsj3sYQISO X-Google-Smtp-Source: ALg8bN77N/WNdIpUBKeuoXgzM8EI/Cx6N0G412ql6zZdLKzXwoYpc4AcbAJhKUbU+8hJ/ceqiMoixw== X-Received: by 2002:a24:7e8c:: with SMTP id h134mr15097785itc.130.1548043981683; Sun, 20 Jan 2019 20:13:01 -0800 (PST) Received: from raichu (toroon0560w-lp130-07-64-229-95-98.dsl.bell.ca. [64.229.95.98]) by smtp.gmail.com with ESMTPSA id p198sm5542577itb.30.2019.01.20.20.13.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 Jan 2019 20:13:01 -0800 (PST) Sender: Mark Johnston Date: Sun, 20 Jan 2019 23:12:59 -0500 From: Mark Johnston To: Enji Cooper Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r343247 - head/usr.bin/cmp/tests Message-ID: <20190121041259.GB96979@raichu> References: <201901210357.x0L3vnIx052453@repo.freebsd.org> <6CF2AD75-F267-4E1F-8505-605BB468D5AF@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) X-Rspamd-Queue-Id: 64E326CEF2 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.989,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jan 2019 04:13:03 -0000 On Sun, Jan 20, 2019 at 08:11:20PM -0800, Enji Cooper wrote: > > > On Jan 20, 2019, at 8:10 PM, Enji Cooper wrote: > > > > > >> On Jan 20, 2019, at 7:57 PM, Mark Johnston wrote: > >> > >> Author: markj > >> Date: Mon Jan 21 03:57:49 2019 > >> New Revision: 343247 > >> URL: https://svnweb.freebsd.org/changeset/base/343247 > >> > >> Log: > >> Fix cmp(1) tests for "special" mode. > >> > >> Test failures don't seem to propagate up if atf_check is run in > >> a pipeline. Thus, the tests continued to pass despite the bug reverted > >> in r343245. > > > > Hmmm… that’s strange… > > -Enji > > There’s a good chance that this issue is also masked by the fact that the CI runs have been panicking with bug 235097 as well. > Cheers, > -Enji No, I ran the tests locally before committing the now-reverted diff.