From nobody Mon Jul 28 13:31:19 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4brKBJ1j9Yz634sV; Mon, 28 Jul 2025 13:31:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4brKBH4RYBz3tmx; Mon, 28 Jul 2025 13:31:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753709479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iMwz7AJEjRolvaojgcbyDyCdhvplfO6SCv8X+Eoi4No=; b=tJP/UhJOAqTAsjvruefOBhAPbFPRI8wNMpoSkaslJLKAld/9Kztef2YLYO37qcuomB5erz Ipdl13wq4KcuEQ1YPc5k1AKg4cUSfGMf0UGlaRw9/YZjW91IAc2d04H16KS6+GyujOamxx BEjKcQhop+PVeNEf/CFSxP0Q2RM/PxTca8x90eTqH/11WIr6VlL3ALTT48lRg6CVS4VNh1 s7YjCqxU3UBga0zdMz/in6slCgwMNqGUxuiI2MUjiQ4NDlE+slZnZKO+fgDgbuO2h6jY6e vI1M4ZwtEUkJ4cybCqQe4Bs0R81Lg/EkGOUDUk3NCnXW3G0tRPgXqgva/yppmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1753709479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iMwz7AJEjRolvaojgcbyDyCdhvplfO6SCv8X+Eoi4No=; b=ZbJalYlzKHu/S+FhD035LNkO+000y4L1A0QJqgIijr6SIdtgZM9qJWwHEwfKhIuaPJWoo6 9oluuj6urzYLgllGfLH2CYbjyeqUy1gpwSKuawU+SvW8Pj4Kqxp5kjC6exLf+Afao1XxOa wFBsmey5dhdCxWcrYevhMrD74y+BcYBHTlqtwrPFvsPdD5oRKua/Jrhy6WVncGySVCCfqg 5flqJLPUgetVGqy8ZxaRnFQakSe2JeyoNTSi+R2NH0shgTbnttFmEnbvggaBSsw+O7YDs1 T0PCLh7XbH71rTS3FsA73m1BCVHOvw21mpbuGnk89SvhRspXRjVFeDl9NG4PMg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1753709479; a=rsa-sha256; cv=none; b=M3POzX+yGQYZB+b1f2EDSohlHaw7KCUHY3OSH/wBP5mZiMzTwcp4dnUjaTuQ+dVLyrOgrc kUuagAbbPanPPpL37Bg5bSajWYgmMykn9anaCiJYAchWru2B4rEl4kIi+h6nepq/w0UYsn XpWiYeOh+oXt8SrwVIcllwlq8dRBi2pzkd7BWJROH0O9J0d0+bVnVAFDhi59fvCagZnhZx mFvGd+7fmwy8DOEvEJW/PJTQNmQJn3f0gbFYcLSDZcSPZ9X6ROsYqxZyBqu5WxbFKxhyaJ 1DuV7hZYr1ucIPiCphc4+U+sLIy49WhWJKdVel2/P7Jh9+5krTOjYMO6n4/gNw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4brKBH2sXtznCL; Mon, 28 Jul 2025 13:31:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 56SDVJfB080228; Mon, 28 Jul 2025 13:31:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 56SDVJbB080225; Mon, 28 Jul 2025 13:31:19 GMT (envelope-from git) Date: Mon, 28 Jul 2025 13:31:19 GMT Message-Id: <202507281331.56SDVJbB080225@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Olivier Certner Subject: git: 9eba574a6761 - stable/14 - runq: New function runq_is_queue_empty(); Use it in ULE List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 9eba574a676191e2f2aaaa0401dcd887e25fb961 Auto-Submitted: auto-generated The branch stable/14 has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=9eba574a676191e2f2aaaa0401dcd887e25fb961 commit 9eba574a676191e2f2aaaa0401dcd887e25fb961 Author: Olivier Certner AuthorDate: 2024-05-23 15:31:06 +0000 Commit: Olivier Certner CommitDate: 2025-07-28 13:28:13 +0000 runq: New function runq_is_queue_empty(); Use it in ULE Indicates if some particular queue of the runqueue is empty. Reviewed by: kib MFC after: 1 month Event: Kitchener-Waterloo Hackathon 202506 Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D45387 (cherry picked from commit a31193172cb98bd1fb242555ca8e122efff74258) --- sys/kern/kern_switch.c | 28 ++++++++++++++++++++++++++++ sys/kern/sched_ule.c | 2 +- sys/sys/runq.h | 1 + 3 files changed, 30 insertions(+), 1 deletion(-) diff --git a/sys/kern/kern_switch.c b/sys/kern/kern_switch.c index eb39ca88992c..b23dfa162c4f 100644 --- a/sys/kern/kern_switch.c +++ b/sys/kern/kern_switch.c @@ -271,10 +271,13 @@ static inline uintptr_t runq_sw_set_not_empty_op(int idx, int sw_idx, rqsw_t sw_bit, rqsw_t *swp); static inline uintptr_t runq_sw_set_empty_op(int idx, int sw_idx, rqsw_t sw_bit, rqsw_t *swp); +static inline uintptr_t runq_sw_is_empty_op(int idx, int sw_idx, + rqsw_t sw_bit, rqsw_t *swp); /* Status words' individual bit manipulators. */ static inline void runq_sw_set_not_empty(struct runq *rq, int idx); static inline void runq_sw_set_empty(struct runq *rq, int idx); +static inline bool runq_sw_is_empty(struct runq *rq, int idx); /* * Initialize a run structure. @@ -358,6 +361,31 @@ runq_sw_set_empty(struct runq *rq, int idx) (void)runq_sw_apply(rq, idx, &runq_sw_set_empty_op); } +static inline uintptr_t +runq_sw_is_empty_op(int idx, int sw_idx, rqsw_t sw_bit, rqsw_t *swp) +{ + return ((*swp & sw_bit) == 0); +} + +/* + * Returns whether the status words indicate that some queue is empty. + */ +static inline bool +runq_sw_is_empty(struct runq *rq, int idx) +{ + return (runq_sw_apply(rq, idx, &runq_sw_is_empty_op)); +} + +/* + * Returns whether a particular queue is empty. + */ +bool +runq_is_queue_empty(struct runq *rq, int idx) +{ + + return (runq_sw_is_empty(rq, idx)); +} + /* * Add the thread to the queue specified by its priority, and set the * corresponding status bit. diff --git a/sys/kern/sched_ule.c b/sys/kern/sched_ule.c index 8fdc71c21e64..d8abb911a887 100644 --- a/sys/kern/sched_ule.c +++ b/sys/kern/sched_ule.c @@ -2605,7 +2605,7 @@ sched_clock(struct thread *td, int cnt) */ if (tdq->tdq_idx == tdq->tdq_ridx) { tdq->tdq_idx = (tdq->tdq_idx + 1) % RQ_NQS; - if (TAILQ_EMPTY(&tdq->tdq_timeshare.rq_queues[tdq->tdq_ridx])) + if (runq_is_queue_empty(&tdq->tdq_timeshare, tdq->tdq_ridx)) tdq->tdq_ridx = tdq->tdq_idx; } ts = td_get_sched(td); diff --git a/sys/sys/runq.h b/sys/sys/runq.h index c570dd25503b..5156a7d8c307 100644 --- a/sys/sys/runq.h +++ b/sys/sys/runq.h @@ -98,6 +98,7 @@ struct runq { }; void runq_init(struct runq *); +bool runq_is_queue_empty(struct runq *, int _idx); void runq_add(struct runq *, struct thread *, int _flags); void runq_add_idx(struct runq *, struct thread *, int _idx, int _flags); bool runq_remove(struct runq *, struct thread *);