Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 1 Feb 2015 20:14:18 +0000 (UTC)
From:      Peter Holm <pho@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r278035 - user/pho/stress2/misc
Message-ID:  <201502012014.t11KEIYR077510@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: pho
Date: Sun Feb  1 20:14:17 2015
New Revision: 278035
URL: https://svnweb.freebsd.org/changeset/base/278035

Log:
  Added a comment.
  
  Sponsored by:	 EMC / Isilon storage division

Modified:
  user/pho/stress2/misc/mmap8.sh
  user/pho/stress2/misc/mmap9.sh

Modified: user/pho/stress2/misc/mmap8.sh
==============================================================================
--- user/pho/stress2/misc/mmap8.sh	Sun Feb  1 20:00:08 2015	(r278034)
+++ user/pho/stress2/misc/mmap8.sh	Sun Feb  1 20:14:17 2015	(r278035)
@@ -38,6 +38,7 @@ dir=/tmp
 odir=`pwd`
 cd $dir
 sed '1,/^EOF/d' < $odir/$0 > $dir/mmap8.c
+# At one point during the fix development, only the thread version would panic
 cc -o mmap8   -Wall -Wextra mmap8.c          || exit 1
 cc -o mmap8p  -Wall -Wextra mmap8.c -pthread || exit 1
 rm -f mmap8.c
@@ -63,6 +64,10 @@ main(void)
 	size_t sz = 1;
 	char *addr;
 
+/*
+ * This is the minimum amount of C code it takes to panic the kernel.
+ * This is as submitted and thus not a complete and correct test program.
+ */
 	addr = mmap(NULL, sz, PROT_READ | PROT_WRITE, MAP_ANON, -1, 0);
 	if (addr == NULL)
 		err(1, "mmap");

Modified: user/pho/stress2/misc/mmap9.sh
==============================================================================
--- user/pho/stress2/misc/mmap9.sh	Sun Feb  1 20:00:08 2015	(r278034)
+++ user/pho/stress2/misc/mmap9.sh	Sun Feb  1 20:14:17 2015	(r278035)
@@ -38,6 +38,7 @@ dir=/tmp
 odir=`pwd`
 cd $dir
 sed '1,/^EOF/d' < $odir/$0 > $dir/mmap9.c
+# At one point during the fix development, only the thread version would panic
 cc -o mmap9  -O2 -Wall -Wextra mmap9.c           || exit 1
 cc -o mmap9p -O2 -Wall -Wextra mmap9.c -lpthread || exit 1
 rm -f mmap9.c
@@ -63,6 +64,10 @@ main(void)
 	size_t sz = 1;
 	char *addr;
 
+/*
+ * This is the minimum amount of C code it takes to panic the kernel.
+ * This is as submitted and thus not a complete and correct test program.
+ */
 	addr = mmap(NULL, sz, PROT_READ | PROT_WRITE, MAP_ANON,
 	    -1, 0);
 	if (addr == NULL)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201502012014.t11KEIYR077510>